Support show_meeting_attendees in v1_meeting #22
Merged
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the show_meeting_attendees field to v1 meetings, enabling LFX One to display meeting attendee data to other attendees. The field is set to true for board meetings associated with TLF project (identified by SFDC ID), and false otherwise.
Key Changes
- Added
ShowMeetingAttendeesboolean field to themeetingInputstruct - Implemented logic to conditionally set the field based on meeting type and project ID
- Imported the
slicespackage for ID checking
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/lfx-v1-sync-helper/models_meetings.go | Added ShowMeetingAttendees boolean field to the meetingInput struct with appropriate JSON tag and documentation |
| cmd/lfx-v1-sync-helper/handlers_meetings.go | Added slices import, logic to set show_meeting_attendees during meeting conversion, and helper function to determine if attendees should be shown based on meeting type and project SFDC ID |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mauriciozanettisalomao
previously approved these changes
Dec 18, 2025
This is a new field being used by LFX One to show data about meeting attendees to other meeting attendees. We need to display this even for v1 meetings, so add to the sync helper to tack it on when it is a board meeting and the project is tlf. Otherwise set to false for now. Signed-off-by: Jordan Evans <jevans@linuxfoundation.org>
jordane
force-pushed
the
jme/LFXV2-921
branch
from
321bfc6 to
469cf40
Compare
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
andrest50
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new field being used by LFX One to show data about meeting attendees to other meeting attendees. We need to display this even for v1 meetings, so add to the sync helper to tack it on when it is a board meeting and the project is tlf. Otherwise set to false for now.