Skip to content

Comments

Standardize v1-objects data decoding with unified abstraction#42

Merged
emsearcy merged 1 commit intomainfrom
bugfix/LFXV2-1115-standardize-v1-objects-decoding
Feb 19, 2026
Merged

Standardize v1-objects data decoding with unified abstraction#42
emsearcy merged 1 commit intomainfrom
bugfix/LFXV2-1115-standardize-v1-objects-decoding

Conversation

@emsearcy
Copy link
Contributor

  • Add getV1ObjectData() abstraction for consistent dual JSON/msgpack decoding
  • Include exists return value to handle tombstones, deletions, and not-found cases
  • Update lookupV1User, getAlternateEmailDetails, and all meetings handlers
  • Remove redundant deletion/tombstone checks from individual functions
  • Ensure all v1-objects bucket reads use consistent format detection
  • Preserve existing handler.go message decoding logic as required
  • Update dependencies with go get -u and go mod tidy

Fixes LFXV2-1115

🤖 Generated with GitHub Copilot (via Zed)

- Add getV1ObjectData() abstraction for consistent dual JSON/msgpack decoding
- Include exists return value to handle tombstones, deletions, and not-found cases
- Update lookupV1User, getAlternateEmailDetails, and all meetings handlers
- Remove redundant deletion/tombstone checks from individual functions
- Ensure all v1-objects bucket reads use consistent format detection
- Preserve existing handler.go message decoding logic as required
- Update dependencies with go get -u and go mod tidy

Fixes LFXV2-1115

🤖 Generated with GitHub Copilot (via Zed)

Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
@emsearcy emsearcy marked this pull request as ready for review February 19, 2026 21:02
@emsearcy emsearcy requested a review from a team as a code owner February 19, 2026 21:02
Copilot AI review requested due to automatic review settings February 19, 2026 21:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a unified abstraction for reading data from the v1-objects KV bucket, standardizing how the codebase handles dual JSON/msgpack encoding and deletion detection. The new getV1ObjectData() function consolidates previously duplicated logic across multiple handlers.

Changes:

  • Added getV1ObjectData() helper function that provides consistent JSON/msgpack decoding and deletion/tombstone detection for v1-objects KV bucket reads
  • Refactored lookupV1User() and getAlternateEmailDetails() to use the new abstraction, removing redundant deletion checks
  • Updated five meeting handler functions to use getV1ObjectData() for consistent data retrieval
  • Updated multiple dependencies to newer patch/minor versions
  • Applied formatting improvements to struct field alignment in config.go and publisher.go

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cmd/lfx-v1-sync-helper/lfx_v1_client.go Added getV1ObjectData() abstraction and refactored lookupV1User() and getAlternateEmailDetails() to use it
cmd/lfx-v1-sync-helper/handlers_meetings.go Updated five meeting-related handlers to use getV1ObjectData() for consistent data access
cmd/lfx-v1-sync-helper/config.go Aligned struct field assignments for better readability
cmd/dynamodb-stream-consumer/publisher.go Aligned struct tag formatting in DynamoDBStreamEvent type
go.mod Updated 9 direct and indirect dependencies to newer versions
go.sum Updated checksums for dependency version changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@emsearcy emsearcy merged commit cda11e8 into main Feb 19, 2026
7 of 8 checks passed
@emsearcy emsearcy deleted the bugfix/LFXV2-1115-standardize-v1-objects-decoding branch February 19, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants