Conversation
- Add getV1ObjectData() abstraction for consistent dual JSON/msgpack decoding - Include exists return value to handle tombstones, deletions, and not-found cases - Update lookupV1User, getAlternateEmailDetails, and all meetings handlers - Remove redundant deletion/tombstone checks from individual functions - Ensure all v1-objects bucket reads use consistent format detection - Preserve existing handler.go message decoding logic as required - Update dependencies with go get -u and go mod tidy Fixes LFXV2-1115 🤖 Generated with GitHub Copilot (via Zed) Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a unified abstraction for reading data from the v1-objects KV bucket, standardizing how the codebase handles dual JSON/msgpack encoding and deletion detection. The new getV1ObjectData() function consolidates previously duplicated logic across multiple handlers.
Changes:
- Added
getV1ObjectData()helper function that provides consistent JSON/msgpack decoding and deletion/tombstone detection for v1-objects KV bucket reads - Refactored
lookupV1User()andgetAlternateEmailDetails()to use the new abstraction, removing redundant deletion checks - Updated five meeting handler functions to use
getV1ObjectData()for consistent data retrieval - Updated multiple dependencies to newer patch/minor versions
- Applied formatting improvements to struct field alignment in config.go and publisher.go
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/lfx-v1-sync-helper/lfx_v1_client.go | Added getV1ObjectData() abstraction and refactored lookupV1User() and getAlternateEmailDetails() to use it |
| cmd/lfx-v1-sync-helper/handlers_meetings.go | Updated five meeting-related handlers to use getV1ObjectData() for consistent data access |
| cmd/lfx-v1-sync-helper/config.go | Aligned struct field assignments for better readability |
| cmd/dynamodb-stream-consumer/publisher.go | Aligned struct tag formatting in DynamoDBStreamEvent type |
| go.mod | Updated 9 direct and indirect dependencies to newer versions |
| go.sum | Updated checksums for dependency version changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jordane
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes LFXV2-1115
🤖 Generated with GitHub Copilot (via Zed)