-
Notifications
You must be signed in to change notification settings - Fork 0
[LFXV2-612] Add OpenTelemetry tracing support #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bec5ace
Add OpenTelemetry tracing support
bramwelt f0145ed
Add OTEL build-time variables and shutdown timeout
bramwelt 2203e5c
Use .ko.yaml for ldflags configuration
bramwelt a1298f4
Add OTel tracing to JWKS client, fix build error
bramwelt 3241e96
Upgrade OTel libraries to v1.40.0
bramwelt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ import ( | |
|
|
||
| "github.com/linuxfoundation/lfx-v2-access-check/internal/infrastructure/config" | ||
| "github.com/linuxfoundation/lfx-v2-access-check/pkg/log" | ||
| "github.com/linuxfoundation/lfx-v2-access-check/pkg/utils" | ||
| ) | ||
|
|
||
| func init() { | ||
|
|
@@ -24,11 +25,25 @@ func main() { | |
| // Load configuration with CLI flags and environment variables | ||
| cfg := config.LoadConfig() | ||
|
|
||
| // Set up OpenTelemetry SDK. | ||
| ctx := context.Background() | ||
| otelConfig := utils.OTelConfigFromEnv() | ||
| otelShutdown, err := utils.SetupOTelSDKWithConfig(ctx, otelConfig) | ||
| if err != nil { | ||
| slog.Error("error setting up OpenTelemetry SDK", "error", err) | ||
| os.Exit(1) | ||
| } | ||
| defer func() { | ||
| if shutdownErr := otelShutdown(context.Background()); shutdownErr != nil { | ||
| slog.Error("error shutting down OpenTelemetry SDK", "error", shutdownErr) | ||
| } | ||
| }() | ||
|
Comment on lines
52
to
58
|
||
|
|
||
| // Setup signal handling for graceful shutdown | ||
| sigChan := make(chan os.Signal, 1) | ||
| signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM) | ||
|
|
||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| ctx, cancel := context.WithCancel(ctx) | ||
| defer cancel() | ||
|
|
||
| go func() { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAMLlint error from standalone template directives in
env:.Line 42 triggers a syntax error because raw
{{- ... }}lines aren’t valid YAML. If YAMLlint scans chart templates in CI, this will fail. Consider excludingcharts/**/templates/**from YAMLlint or switching that stage to a Helm-aware linting approach.If you want, I can propose a concrete YAMLlint configuration change to keep templates linted safely.
Also applies to: 44-93
🧰 Tools
🪛 YAMLlint (1.38.0)
[error] 42-42: syntax error: could not find expected ':'
(syntax)
🤖 Prompt for AI Agents