add resource and replica support

[AlanSherman]

No description provided.

[coderabbitai]

Walkthrough

This Helm chart update increases the default replica count from 1 to 3, adds conditional resource limits and requests for the app container, updates the deployment template to render resources when provided, and bumps the chart version to 0.2.5.

Changes

Cohort / File(s)	Summary
Version Bump charts/lfx-v2-access-check/Chart.yaml	Chart version incremented from 0.2.4 to 0.2.5
Configuration Updates charts/lfx-v2-access-check/values.yaml	Replica count increased from 1 to 3; added app.resources with CPU limits (500m), CPU requests (100m), memory limits (512Mi), and memory requests (128Mi)
Template Enhancement charts/lfx-v2-access-check/templates/deployment.yaml	Added conditional resources block under app container that renders toYaml of .Values.app.resources with 12-space indentation when resources are provided

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify the 12-space indentation in the deployment template aligns with container field standards
• Confirm resource values (500m CPU limit, 128Mi memory request) are appropriate for the application workload
• Validate that increasing replica count from 1 to 3 does not introduce state/concurrency concerns if the service maintains local state

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author.	Add a description explaining the motivation for adding resource and replica support, such as deployment requirements or infrastructure improvements.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main changes: adding resource limits/requests and increasing replica count support in the Helm chart.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch asherman/helm-resources

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between eec49d0 and 3c3b6d0.

📒 Files selected for processing (3)

• charts/lfx-v2-access-check/Chart.yaml (1 hunks)
• charts/lfx-v2-access-check/templates/deployment.yaml (1 hunks)
• charts/lfx-v2-access-check/values.yaml (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

charts/lfx-v2-access-check/**

📄 CodeRabbit inference engine (CLAUDE.md)

Helm charts for Kubernetes deployment must be placed in the charts/lfx-v2-access-check directory

Files:

• charts/lfx-v2-access-check/templates/deployment.yaml
• charts/lfx-v2-access-check/values.yaml
• charts/lfx-v2-access-check/Chart.yaml

🧠 Learnings (1)

📚 Learning: 2025-08-07T15:22:00.043Z

Learnt from: CR
Repo: linuxfoundation/lfx-v2-access-check PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-08-07T15:22:00.043Z
Learning: Applies to charts/lfx-v2-access-check/** : Helm charts for Kubernetes deployment must be placed in the charts/lfx-v2-access-check directory

Applied to files:

• charts/lfx-v2-access-check/templates/deployment.yaml
• charts/lfx-v2-access-check/Chart.yaml

🪛 YAMLlint (1.37.1)

charts/lfx-v2-access-check/templates/deployment.yaml

[error] 42-42: syntax error: could not find expected ':'

(syntax)

🔇 Additional comments (5)

charts/lfx-v2-access-check/Chart.yaml (1)

8-8: Version bump aligns with feature additions.

The chart version increment to 0.2.5 appropriately reflects the new replica count and resource configuration features introduced in this PR.

charts/lfx-v2-access-check/values.yaml (2)

4-4: Replica count increased to 3 for improved availability.

Scaling from 1 to 3 replicas improves fault tolerance and load distribution. Ensure this aligns with your cluster capacity and verify the application is stateless or properly handles session replication.

---

27-34: Resource limits and requests added with reasonable defaults.

The resource configuration provides proper CPU and memory bounds:

• Requests (100m CPU, 128Mi memory) allow the scheduler to make informed placement decisions
• Limits (500m CPU, 512Mi memory) prevent resource runaway

Ensure these values match your actual workload metrics and monitoring data.

charts/lfx-v2-access-check/templates/deployment.yaml (2)

41-44: Conditional resources block follows Helm templating best practices.

The use of {{- if .Values.app.resources }} with toYaml and nindent 12 is idiomatic and correctly renders the resources specification at the container level. The indentation aligns properly with sibling fields like env, livenessProbe, and readinessProbe.

---

41-44: No action needed—YAMLlint error is not applicable to Helm templates.

The .yamllint.yml configuration in the repository explicitly ignores chart templates: ignore: | charts/*/templates/**. This means YAMLlint does not lint these files, so the error flagged in your review comment will not appear in your CI/CD pipeline.

The template code itself is correct: the conditional resources: block with nindent 12 follows Helm best practices and is properly indented for container spec level. The template will render correctly when app.resources is defined in values.yaml (which it is) and will omit the resources block when undefined.

Likely an incorrect or invalid review comment.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull Request Overview

This PR adds Kubernetes resource management capabilities to the lfx-v2-access-check Helm chart, enabling better control over CPU and memory allocation for the access check service pods.

• Introduces configurable resource limits and requests in the values file
• Updates the deployment template to apply these resource constraints to containers
• Bumps the chart version from 0.2.4 to 0.2.5

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
charts/lfx-v2-access-check/values.yaml	Adds default resource limits (500m CPU, 512Mi memory) and requests (100m CPU, 128Mi memory)
charts/lfx-v2-access-check/templates/deployment.yaml	Conditionally applies resource constraints from values to the container spec
charts/lfx-v2-access-check/Chart.yaml	Increments chart version to reflect the new resource management feature

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.