Skip to content

LFXV2-872: Tie chart releases to app releases#23

Open
emsearcy wants to merge 1 commit intomainfrom
LFXV2-872-tie-chart-releases-to-app-releases
Open

LFXV2-872: Tie chart releases to app releases#23
emsearcy wants to merge 1 commit intomainfrom
LFXV2-872-tie-chart-releases-to-app-releases

Conversation

@emsearcy
Copy link

@emsearcy emsearcy commented Feb 4, 2026

This PR implements the standardized changes for LFXV2-872 to tie chart releases to app releases.

Changes Made

Chart.yaml Updates

  • Reset version from 0.3.4 to 0.0.1
  • Added explanatory comment about dynamic version replacement during chart build
  • Maintained appVersion: "latest" (already correct)

GitHub Workflow Updates

  • Updated CHART_VERSION calculation to use github.ref_name instead of reading from Chart.yaml
  • Updated helm-chart-oci-publisher to newer version @17e4144d7ba68f7c3e8c16eece5aed15fd7c2dc8

Related

  • Jira: LFXV2-872 - Tie chart releases to app releases
  • Pattern: Standardized changes applied across all LFX v2 repositories

Testing

The changes ensure that:

  • Chart version is dynamically set to match the release tag during builds
  • Chart builds use the updated publisher with latest features
  • Version consistency between application and chart releases

Reset Chart.yaml version to 0.0.1 with explanatory comment.
Update workflow to derive CHART_VERSION from git tag instead of Chart.yaml.
Update helm-chart-oci-publisher to newer version @17e4144d7ba68f7c3e8c16eece5aed15fd7c2dc8.

🤖 Generated with [GitHub Copilot](https://github.com/features/copilot) (via Zed)

Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
@emsearcy emsearcy requested a review from a team as a code owner February 4, 2026 00:20
Copilot AI review requested due to automatic review settings February 4, 2026 00:20
@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Walkthrough

This pull request updates the Helm chart versioning strategy and CI/CD workflow configuration. The chart version is now statically set to 0.0.1 with documentation that it will be dynamically replaced during the build process, and the workflow is modified to derive the chart version from the GitHub release tag instead of reading from the Chart.yaml file.

Changes

Cohort / File(s) Summary
Helm Chart Configuration
charts/lfx-v2-auth-service/Chart.yaml
Chart version updated from 0.3.4 to 0.0.1 with added comments indicating version will be dynamically replaced during build.
CI/CD Workflow
.github/workflows/ko-build-tag.yaml
CHART_VERSION calculation changed to derive from GitHub ref name instead of reading from Chart.yaml via yq; Helm chart publication action updated to new commit hash.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and directly summarizes the main change: tying chart releases to app releases, matching the primary objective of the PR.
Description check ✅ Passed The description is comprehensive and directly related to the changeset, detailing the Chart.yaml updates and GitHub workflow modifications with clear explanations.
Linked Issues check ✅ Passed The PR fully implements the requirements from LFXV2-872: CHART_VERSION now derives from github.ref_name with v-stripping, and Chart.yaml version is reset for dynamic replacement.
Out of Scope Changes check ✅ Passed All changes directly address the linked issue objective: modifying workflow to use github.ref_name for CHART_VERSION and updating Chart.yaml as required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch LFXV2-872-tie-chart-releases-to-app-releases

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements standardized changes to tie Helm chart releases directly to application releases by making the chart version dynamically match the git tag version instead of being manually maintained.

Changes:

  • Reset Chart.yaml version from 0.3.4 to 0.0.1 with explanatory comments about dynamic replacement during build
  • Modified workflow to derive CHART_VERSION from the git tag (github.ref_name) instead of reading from Chart.yaml
  • Updated helm-chart-oci-publisher action to a newer commit version

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
charts/lfx-v2-auth-service/Chart.yaml Reset version to 0.0.1 and added comments explaining that the version is dynamically replaced during chart builds
.github/workflows/ko-build-tag.yaml Changed CHART_VERSION calculation to use github.ref_name and updated helm-chart-oci-publisher to newer version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +8 to +10
# This version should not be incremented, as it is dynamically replaced with the release version during the chart build
# job.
version: 0.0.1
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md documentation is now outdated and contradicts these changes. Lines 153-154 and 190-191 instruct users to manually update the chart version in Chart.yaml before releases, but this PR changes the approach so that the chart version is now dynamically set to match the release tag. The documentation should be updated to reflect this new workflow where the chart version should not be manually incremented.

Copilot uses AI. Check for mistakes.
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/ko-build-tag.yaml (1)

35-39: ⚠️ Potential issue | 🟡 Minor

Use anchored sed pattern to remove only the leading "v" from version tags.

The current sed 's/v//g' removes all "v" characters globally. While standard semantic versioning (v1.2.3, v1.2.3-alpha, etc.) avoids embedded "v" in identifiers, using sed 's/^v//' is more precise and defensive, removing only the leading "v".

🛠️ Suggested change
-          APP_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g')
+          APP_VERSION=$(echo ${{ github.ref_name }} | sed 's/^v//')
           CHART_NAME="$(yq '.name' charts/*/Chart.yaml)"
-          CHART_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g')
+          CHART_VERSION=$(echo ${{ github.ref_name }} | sed 's/^v//')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants