Conversation
Reset Chart.yaml version to 0.0.1 with explanatory comment. Update workflow to derive CHART_VERSION from git tag instead of Chart.yaml. Update helm-chart-oci-publisher to newer version @17e4144d7ba68f7c3e8c16eece5aed15fd7c2dc8. 🤖 Generated with [GitHub Copilot](https://github.com/features/copilot) (via Zed) Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
WalkthroughThis pull request updates the Helm chart versioning strategy and CI/CD workflow configuration. The chart version is now statically set to 0.0.1 with documentation that it will be dynamically replaced during the build process, and the workflow is modified to derive the chart version from the GitHub release tag instead of reading from the Chart.yaml file. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR implements standardized changes to tie Helm chart releases directly to application releases by making the chart version dynamically match the git tag version instead of being manually maintained.
Changes:
- Reset Chart.yaml version from 0.3.4 to 0.0.1 with explanatory comments about dynamic replacement during build
- Modified workflow to derive CHART_VERSION from the git tag (github.ref_name) instead of reading from Chart.yaml
- Updated helm-chart-oci-publisher action to a newer commit version
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/lfx-v2-auth-service/Chart.yaml | Reset version to 0.0.1 and added comments explaining that the version is dynamically replaced during chart builds |
| .github/workflows/ko-build-tag.yaml | Changed CHART_VERSION calculation to use github.ref_name and updated helm-chart-oci-publisher to newer version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # This version should not be incremented, as it is dynamically replaced with the release version during the chart build | ||
| # job. | ||
| version: 0.0.1 |
There was a problem hiding this comment.
The README.md documentation is now outdated and contradicts these changes. Lines 153-154 and 190-191 instruct users to manually update the chart version in Chart.yaml before releases, but this PR changes the approach so that the chart version is now dynamically set to match the release tag. The documentation should be updated to reflect this new workflow where the chart version should not be manually incremented.
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ko-build-tag.yaml (1)
35-39:⚠️ Potential issue | 🟡 MinorUse anchored sed pattern to remove only the leading "v" from version tags.
The current
sed 's/v//g'removes all "v" characters globally. While standard semantic versioning (v1.2.3, v1.2.3-alpha, etc.) avoids embedded "v" in identifiers, usingsed 's/^v//'is more precise and defensive, removing only the leading "v".🛠️ Suggested change
- APP_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g') + APP_VERSION=$(echo ${{ github.ref_name }} | sed 's/^v//') CHART_NAME="$(yq '.name' charts/*/Chart.yaml)" - CHART_VERSION=$(echo ${{ github.ref_name }} | sed 's/v//g') + CHART_VERSION=$(echo ${{ github.ref_name }} | sed 's/^v//')
This PR implements the standardized changes for LFXV2-872 to tie chart releases to app releases.
Changes Made
Chart.yaml Updates
0.3.4to0.0.1appVersion: "latest"(already correct)GitHub Workflow Updates
CHART_VERSIONcalculation to usegithub.ref_nameinstead of reading from Chart.yamlhelm-chart-oci-publisherto newer version@17e4144d7ba68f7c3e8c16eece5aed15fd7c2dc8Related
Testing
The changes ensure that: