Skip to content

[LFXV2-1039] Add voting service chart to lfx-platform helm chart#107

Merged
andrest50 merged 1 commit intomainfrom
andrest50/voting-service-chart
Jan 29, 2026
Merged

[LFXV2-1039] Add voting service chart to lfx-platform helm chart#107
andrest50 merged 1 commit intomainfrom
andrest50/voting-service-chart

Conversation

@andrest50
Copy link
Contributor

@andrest50 andrest50 commented Jan 29, 2026

Summary

Add the lfx-v2-voting-service as a dependency to the lfx-platform helm chart to enable deployment of the voting service.

Changes

  • Added lfx-v2-voting-service v0.1.0 as a chart dependency in Chart.yaml
  • Configured default values with domain settings and reloader annotations
  • Updated Chart.lock with the new dependency

Configuration

  • Version: ~0.1.0
  • Repository: oci://ghcr.io/linuxfoundation/lfx-v2-voting-service/chart
  • Enabled by default with reloader annotations for auto-restart on config changes

Ticket

LFXV2-1039

Add lfx-v2-voting-service v0.1.0 as a dependency to the platform chart with default configuration including domain settings and reloader annotations.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Signed-off-by: Andres Tobon <andrest2455@gmail.com>
@andrest50 andrest50 requested a review from emsearcy as a code owner January 29, 2026 19:44
Copilot AI review requested due to automatic review settings January 29, 2026 19:44
@andrest50 andrest50 requested a review from a team as a code owner January 29, 2026 19:44
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Walkthrough

Added a new Helm chart dependency for lfx-v2-voting-service to the lfx-platform chart. Updated Chart.yaml with dependency declaration and values.yaml with service configuration, including reloader annotations for automatic ConfigMap and Secret updates.

Changes

Cohort / File(s) Summary
Helm Chart Configuration
charts/lfx-platform/Chart.yaml, charts/lfx-platform/values.yaml
Added new dependency entry for lfx-v2-voting-service with OCI repository and version ~0.1.0. Introduced configuration block for the service with enabled: true, domain settings, and reloader annotations. Also added reloader annotations to lfx-v2-meeting-service for automatic ConfigMap/Secret reload triggers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding the voting service chart to the lfx-platform Helm chart.
Description check ✅ Passed The description is directly related to the changeset, providing a clear summary, detailed changes, and configuration details that match the modifications made.
Linked Issues check ✅ Passed The PR successfully addresses all requirements from LFXV2-1039: adds the voting service as a dependency with correct version and repository, configures domain settings and reloader annotations, and updates Chart.lock.
Out of Scope Changes check ✅ Passed All changes in the PR are directly scoped to the linked issue requirements; no out-of-scope modifications were identified beyond the intended Helm chart updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch andrest50/voting-service-chart

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR wires the lfx-v2-voting-service into the lfx-platform Helm chart as a managed dependency with sane defaults and lockfile updates.

Changes:

  • Added lfx-v2-voting-service as a chart dependency in Chart.yaml with version constraint ~0.1.0 and conditional enablement.
  • Introduced default values for lfx-v2-voting-service in values.yaml, including domain configuration and reloader annotations for automatic restarts on config changes.
  • Regenerated Chart.lock to pin the new dependency and update some existing dependency versions and the digest/timestamp.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
charts/lfx-platform/values.yaml Adds lfx-v2-voting-service defaults (enable flag, domain, and reloader annotations), consistent with neighboring v2 services.
charts/lfx-platform/Chart.yaml Registers lfx-v2-voting-service as a Helm dependency with the specified OCI repository and version range, gated by an enabled condition.
charts/lfx-platform/Chart.lock Locks the resolved version of lfx-v2-voting-service and updates several existing dependency versions plus the lock digest and generated timestamp.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@andrest50 andrest50 merged commit b248d20 into main Jan 29, 2026
10 checks passed
@andrest50 andrest50 deleted the andrest50/voting-service-chart branch January 29, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants