Skip to content

bump: auth-service v0.3.1 - email linking flow - Authelia#74

Merged
mauriciozanettisalomao merged 1 commit intolinuxfoundation:mainfrom
mauriciozanettisalomao:feat/lfxv2-502-auth-service-email-linking-authelia
Oct 30, 2025
Merged

bump: auth-service v0.3.1 - email linking flow - Authelia#74
mauriciozanettisalomao merged 1 commit intolinuxfoundation:mainfrom
mauriciozanettisalomao:feat/lfxv2-502-auth-service-email-linking-authelia

Conversation

@mauriciozanettisalomao
Copy link
Contributor

Overview

Jira Ticket: https://linuxfoundation.atlassian.net/browse/LFXV2-502

This pull request updates the authentication service configuration for the platform chart. The main change is switching the user repository type to use authelia and upgrading the lfx-v2-auth-service chart dependency to a newer version.

Authentication service updates:

  • Changed USER_REPOSITORY_TYPE from mock to authelia in charts/lfx-platform/values.yaml, which means the authentication service will now use Authelia for user management instead of the mock repository.

Dependency version bump:

  • Updated the lfx-v2-auth-service chart dependency version from ~0.2.7 to ~0.3.1 in charts/lfx-platform/Chart.yaml to ensure compatibility with the new user repository type and any related improvements.

Note

I've updated the USER_REPOSITORY_TYPE from mock to authelia for auth-service, since if the service is being managed via this repo, it's very likely that it's using the full local setup, including Authelia.

… and lfx-v2-auth-service versions

- nats version updated from 1.3.15 to 1.3.16
- authelia version updated from 0.10.46 to 0.10.47
- lfx-v2-meeting-service version updated from 0.4.17 to 0.4.22
- lfx-v2-auth-service version updated from 0.2.7 to 0.3.1
- updated USER_REPOSITORY_TYPE in values.yaml from 'mock' to 'authelia'

Jira Ticket: https://linuxfoundation.atlassian.net/browse/LFXV2-502

Signed-off-by: Mauricio Zanetti Salomao <mauriciozanetti86@gmail.com>
Copilot AI review requested due to automatic review settings October 30, 2025 12:54
@coderabbitai
Copy link

coderabbitai bot commented Oct 30, 2025

Walkthrough

Updates the lfx-v2-auth-service Helm chart dependency from version ~0.2.7 to ~0.3.1 and changes the USER_REPOSITORY_TYPE configuration value from mock to authelia in the lfx-platform chart values.

Changes

Cohort / File(s) Change Summary
lfx-v2-auth-service integration
charts/lfx-platform/Chart.yaml, charts/lfx-platform/values.yaml
Bumped lfx-v2-auth-service dependency from ~0.2.7 to ~0.3.1; switched USER_REPOSITORY_TYPE environment variable from mock to authelia

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Verify the lfx-v2-auth-service v0.3.1 compatibility with the updated USER_REPOSITORY_TYPE configuration
  • Confirm the transition from mock to authelia as the repository type is intentional and properly tested

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Linked Issues Check ❓ Inconclusive The linked issue LFXV2-502 specifies detailed acceptance criteria for implementing email verification flows, OTP code generation and storage in KV, NATS endpoints, race condition protection, and other authentication features. However, the PR contains only configuration and dependency updates (Chart.yaml and values.yaml changes) without implementing any of the specific coding requirements outlined in the issue. While the version bump to v0.3.1 may include these implementations within the external lfx-v2-auth-service package, the PR itself does not contain visible implementations of the acceptance criteria. To conclusively determine compliance, clarify whether the v0.3.1 release of lfx-v2-auth-service includes implementations of all LFXV2-502 acceptance criteria (email verification flows, OTP generation, NATS endpoints, KV integration, etc.). If the implementations are in v0.3.1, document this in the PR or provide a reference to the release notes. Alternatively, if implementation code is expected in this PR, add the required service-layer changes before merging.
✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "bump: auth-service v0.3.1 - email linking flow - Authelia" directly describes the two main changes in the PR: the version bump of the lfx-v2-auth-service dependency from ~0.2.7 to ~0.3.1, and the configuration change to enable Authelia for user management. The title is concise, specific, and clearly communicates the primary intent of the changeset to teammates reviewing the history.
Out of Scope Changes Check ✅ Passed Both changes in the PR are directly related to the objectives of LFXV2-502. The version bump of lfx-v2-auth-service to v0.3.1 and the configuration change from USER_REPOSITORY_TYPE mock to authelia are both supporting changes meant to enable Authelia integration for email linking flow as described in the linked issue. No unrelated or extraneous changes are present in the PR.
Description Check ✅ Passed The pull request description is clearly related to the changeset and provides meaningful context about the changes. It explains both modifications (the USER_REPOSITORY_TYPE configuration change and the dependency version bump), references the associated Jira ticket (LFXV2-502), and provides reasoning for why Authelia was chosen over the mock repository for the local setup. The description adequately communicates what was changed and why.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9a99f21 and 16231f3.

⛔ Files ignored due to path filters (1)
  • charts/lfx-platform/Chart.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • charts/lfx-platform/Chart.yaml (1 hunks)
  • charts/lfx-platform/values.yaml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-29T16:53:12.710Z
Learnt from: mauriciozanettisalomao
PR: linuxfoundation/lfx-v2-helm#49
File: charts/lfx-platform/Chart.yaml:8-8
Timestamp: 2025-08-29T16:53:12.710Z
Learning: The maintainer mauriciozanettisalomao prefers to keep chart version increments conservative, choosing 0.2.7 over suggested 0.3.0 even for changes that could be considered behavior-altering (like new middleware and JSON Content-Type enforcement in Heimdall).

Applied to files:

  • charts/lfx-platform/Chart.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: MegaLinter
🔇 Additional comments (2)
charts/lfx-platform/Chart.yaml (1)

85-85: Verify lfx-v2-auth-service v0.3.1 includes all email-linking features.

Given that you previously favored conservative version bumps, this jump from ~0.2.7 to ~0.3.1 warrants confirmation. Ensure that v0.3.1 includes all acceptance criteria from LFXV2-502 (OTP generation/validation, KV storage integration, NATS endpoints, race-condition protection, and mock identity linking).

You may want to check the lfx-v2-auth-service release notes or changelog to confirm feature completeness and any breaking changes in the 0.3.x line.

charts/lfx-platform/values.yaml (1)

595-610: Configuration change looks good.

The switch from mock to authelia is well-documented and all supporting environment variables (AUTHELIA_CONFIGMAP_NAME, AUTHELIA_CONFIGMAP_NAMESPACE, etc.) are properly configured and reference existing resources defined elsewhere in the chart. The inline comments clearly explain the repository types and link to relevant documentation.

If this hasn't already been tested in a local setup, consider verifying that the referenced Authelia resources (ConfigMap authelia-users, namespace lfx, DaemonSet lfx-platform-authelia) are properly provisioned when the chart is deployed, to catch any resource reference issues early.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the authentication configuration for the lfx-platform chart by switching from mock authentication to Authelia and upgrading related dependencies.

  • Changed default USER_REPOSITORY_TYPE from mock to authelia for production-ready authentication
  • Updated lfx-v2-auth-service chart version from ~0.2.7 to ~0.3.1
  • Upgraded several dependency versions including NATS, Authelia, and lfx-v2-meeting-service

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
charts/lfx-platform/values.yaml Changed USER_REPOSITORY_TYPE from mock to authelia for authentication service
charts/lfx-platform/Chart.yaml Upgraded lfx-v2-auth-service dependency from ~0.2.7 to ~0.3.1
charts/lfx-platform/Chart.lock Updated lock file reflecting new versions of nats (1.3.16), authelia (0.10.47), lfx-v2-meeting-service (0.4.22), and lfx-v2-auth-service (0.3.1)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mauriciozanettisalomao mauriciozanettisalomao merged commit a69c0af into linuxfoundation:main Oct 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants