Skip to content

feat: Add configurable algorithm option for heimdall key generation #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emsearcy merged 1 commit into from
Dec 12, 2025
+4 −2
Merged

feat: Add configurable algorithm option for heimdall key generation #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/lfx-platform/templates/heimdall/heimdall-signer-cert.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
---
{{ if and .Values.heimdall.enabled .Values.lfx.generateHeimdallSignerCert.enabled -}}
{{/*
Generate a P-256 curve key & x509 cert for Heimdall on install of Chart
Generate a private key & x509 cert for Heimdall on install of Chart
TODO: Create RBAC rule to limit secret access to heimdall Pods
*/}}
{{- $heimdallCA := genCAWithKey "heimdall" 365 (genPrivateKey "ecdsa")}}
{{- $heimdallCA := genCAWithKey "heimdall" 365 (genPrivateKey .Values.lfx.generateHeimdallSignerCert.algorithm) -}}

apiVersion: v1
kind: Secret
Expand Down
2 changes: 2 additions & 0 deletions charts/lfx-platform/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ lfx:
generateHeimdallSignerCert:
enabled: true
name: heimdall-signer-cert
# algorithm will be passed as the parameter to Sprig's genPrivateKey.
algorithm: rsa

whoami:
enabled: true
Expand Down