Skip to content

Conversation

@emsearcy
Copy link
Contributor

@emsearcy emsearcy commented Nov 5, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 5, 2025 18:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new mock data generation tool for the LFX v2 platform. The tool uses YAML playbooks with Jinja2 templating to create test data through HTTP requests, NATS messaging, and KV store operations.

  • Implements a playbook-based system supporting multiple workflow types (HTTP requests, NATS publish/request, NATS KV operations)
  • Includes custom YAML tags (!ref, !sub, !include) for dynamic data referencing and templating
  • Provides sample playbooks for populating projects, committees, and permissions

Reviewed Changes

Copilot reviewed 21 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
uv.lock Lockfile defining all dependencies including faker, nats-py, pydantic, jinja2
src/lfx_v2_mockdata/init.py Main script implementing playbook execution engine with JMESPath support
src/custom_logging/init.py Structured logging configuration with JSON and console output
pyproject.toml Project configuration with dependencies and tooling setup
README.md Documentation for setup, usage, and playbook structure
playbooks/* YAML playbooks defining data generation scenarios
scripts/mock-heimdall-jwt.sh Helper script for generating authentication tokens
LICENSE* MIT license for code, CC-BY-4.0 for documentation
.github/workflows/* CI/CD workflows for linting and license checks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Also remove the +x bit from the lfx_v2_mockdata script and remove its
shebang line, since it's not intended to be executed directly.

Signed-off-by: Eric Searcy <[email protected]>
@emsearcy emsearcy requested a review from bramwelt November 5, 2025 18:27
Linting, vulnerabilities, etc.

Signed-off-by: Eric Searcy <[email protected]>
@emsearcy
Copy link
Contributor Author

emsearcy commented Nov 6, 2025

gitleaks seems to be failing but it's seeing files in #1

The main reason for adding this was in order to exclude the "playbooks"
folder, because yamllint cannot lint pre-rendered Jinja2 templates.

Signed-off-by: Eric Searcy <[email protected]>
@emsearcy emsearcy force-pushed the python-implementation branch from 541a602 to a05f513 Compare November 12, 2025 17:54
Signed-off-by: Eric Searcy <[email protected]>
@emsearcy
Copy link
Contributor Author

gitleaks seems to be failing but it's seeing files in #1

This has been fixed with a force-push to #1 (thanks @bramwelt ) — MegaLinter is passing here now.

Copy link
Contributor

@andrest50 andrest50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll defer to @bramwelt if he has any comments since he was also working on mocking. Otherwise, it's fine to merge.

@emsearcy emsearcy merged commit 8c1ef94 into linuxfoundation:main Nov 14, 2025
3 checks passed
@emsearcy emsearcy deleted the python-implementation branch November 15, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants