Skip to content

Conversation

@andrest50
Copy link
Contributor

This pull request updates the board meeting playbook to improve support for v2 attributes and ensure consistency in data modeling for meetings, recordings, transcripts, and summaries. The main changes involve adding explicit id fields for v2 compatibility and updating the subject for summary publishing.

Data Model Updates

  • Added explicit id fields (v2 attribute) to meeting, participant, recording, and transcript creation steps to standardize v2 data modeling. (buf_board_meeting_create, buf_board_meeting_committee_participants_create, buf_board_past_meeting_{{ past_meeting_index }}_create, buf_board_past_meeting_{{ past_meeting_index }}_recording_create, buf_board_past_meeting_{{ past_meeting_index }}_transcript_create) [1] [2] [3] [4] [5]
  • In participant creation, retained the existing registrant_id (v1 attribute) for backward compatibility while adding the new id field. (buf_board_meeting_committee_participants_create)

Summary Publishing

  • Changed the NATS subject for meeting summary publishing from lfx.index.v1_meeting_summary to lfx.index.v1_past_meeting_summary to better reflect the data type and improve event routing. (buf_board_past_meeting_{{ past_meeting_index }}_summary_create)

@andrest50 andrest50 marked this pull request as ready for review November 25, 2025 03:56
Copilot AI review requested due to automatic review settings November 25, 2025 03:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the board meeting playbook by adding explicit v2-compatible id fields to meeting-related data models and correcting a NATS subject name for improved clarity.

  • Added v2 id attributes to meeting, participant, recording, and transcript data models for standardization
  • Updated NATS subject from v1_meeting_summary to v1_past_meeting_summary for consistency with other past meeting entities
  • Maintained backward compatibility by retaining v1 registrant_id attribute alongside the new v2 id field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@emsearcy emsearcy merged commit 1f7aa43 into main Nov 25, 2025
3 checks passed
@emsearcy emsearcy deleted the andrest50/v1-meetings-mock branch November 25, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants