fix: correct data references and update M2M authentication config #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify committee category to use single value - Update JWT authentication to use proper M2M principal format - Rename M2M client from m2m_test to lfx_m2m for production - Fix meeting recording/transcript/participant references to use correct .id field Signed-off-by: Asitha de Silva <[email protected]>
emsearcy
approved these changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects data field references and standardizes authentication configuration across the playbooks. The changes fix incorrect field paths that were using compound identifiers instead of the correct .id field, update M2M client naming for production alignment, and modernize JWT authentication configuration.
- Corrected data field references from
.meeting_and_occurrence_idand.registrant_idto.idto match actual data structures - Updated M2M authentication: renamed client from
m2m_testtolfx_m2min OpenFGA tuples, and migrated from environment variable tokens to!jwttag format - Simplified committee category from compound path to single value
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| playbooks/v1_meetings/umbrella_board_meeting/board_meeting.yaml | Fixed recording, transcript, and participant field references to use correct .id field instead of compound identifiers |
| playbooks/projects/root_project_access/global_groups.yaml | Renamed M2M client from m2m_test to lfx_m2m for production alignment in OpenFGA authorization tuples |
| playbooks/projects/base_projects/3_umbrellas.yaml | Migrated JWT authentication from environment variable token to !jwt tag format with M2M principal |
| playbooks/committees/base_committees/buf_committees.yaml | Simplified Technical Oversight Committee category from compound path to single value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
!jwttag with M2M principal formatm2m_testtolfx_m2mfor production alignment.idfield instead of.meeting_and_occurrence_idand.registrant_id🤖 Generated with Claude Code