Open
Conversation
Enhanced error handling in the HTTP request playbook runner to include the response body when API requests fail. This provides more detailed error messages that help diagnose issues like 400 Bad Request errors by showing the actual validation errors or error details returned by the API. The error message now includes both the HTTP status and the complete response body when available, making it much easier to debug API issues. Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Andres Tobon <andrest2455@gmail.com>
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
Added a new playbook step to create meeting RSVP (invite response) mock data for board member registrants. This publishes RSVP events to the lfx.index.v1_meeting_rsvp NATS subject for indexing in OpenSearch. The RSVP data includes: - Unique ID and registrant association - Meeting and occurrence references - User information (name, email, username, org, job title) - Response status (accepted/declined/maybe) with random selection - Scope set to "all" for applying to all meeting occurrences - Response date, SES message ID, and email details - Creation and modification timestamps All fields match the inviteResponseInput Go struct schema to ensure compatibility with the indexer service. Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Andres Tobon <andrest2455@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds v1 meeting RSVP mock data for board member registrants in the umbrella board meeting playbook, improves HTTP error handling with detailed response bodies, and fixes an invalid committee category name.
Key Changes:
- New playbook step to create meeting RSVP mock data that publishes to the NATS indexing subject
- Enhanced HTTP error messages to include API response bodies for better debugging
- Updated committee category from "Technical Oversight Committee" to "Technical Steering Committee"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/lfx_v2_mockdata/__init__.py |
Enhanced error handling to capture and include response body in error messages for failed HTTP requests |
playbooks/v1_meetings/umbrella_board_meeting/board_meeting.yaml |
Added new buf_board_meeting_committee_participants_rsvps_create step to generate RSVP mock data for board members with response status, timestamps, and user details |
playbooks/committees/base_committees/buf_committees.yaml |
Fixed committee name and category from "Technical Oversight Committee" to "Technical Steering Committee" for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
playbooks/v1_meetings/umbrella_board_meeting/board_meeting.yaml
Outdated
Show resolved
Hide resolved
playbooks/v1_meetings/umbrella_board_meeting/board_meeting.yaml
Outdated
Show resolved
Hide resolved
playbooks/v1_meetings/umbrella_board_meeting/board_meeting.yaml
Outdated
Show resolved
Hide resolved
Ensure data consistency by having RSVP records reference the same username and job_title from the registrant record instead of generating new random values. This prevents the same person from having different usernames and job titles across records. Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Andres Tobon <andrest2455@gmail.com>
Remove lazy exception handling when accessing requests.Response.text property, which is designed to never throw exceptions. This eliminates the security warning while simplifying the code. Also updated Python dependencies via `uv sync -U` (uv.lock file). 🤖 Generated with GitHub Copilot (https://github.com/features/copilot) (via Zed) Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
Signed-off-by: Andres Tobon <andrest2455@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
RSVP Mock Data
Added a new playbook step (
buf_board_meeting_committee_participants_rsvps_create) that creates meeting RSVP (invite response) mock data for board member registrants. This publishes RSVP events to thelfx.index.v1_meeting_rsvpNATS subject for indexing in OpenSearch.The RSVP data includes:
All fields match the
inviteResponseInputGo struct schema to ensure compatibility with the indexer service.Error Message Improvements
Enhanced error handling in the HTTP request playbook runner to include the response body when API requests fail. This provides more detailed error messages that help diagnose issues like 400 Bad Request errors by showing the actual validation errors or error details returned by the API.
Committee Category Fix
Fixed an invalid committee category in the base committees playbook that was causing validation errors.
Ticket
LFXV2-884
Generated with Claude Code