-
Notifications
You must be signed in to change notification settings - Fork 2
do not generate spec for /livez or /readyz #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jordan Evans <jevans@linuxfoundation.org>
WalkthroughAdded swagger generation suppression metadata to the readyz and livez endpoints in design/query-svc.go using dsl.Meta("swagger:generate", "false"). No other changes to routes, results, or errors. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)design/**📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the health check endpoints (/livez and /readyz) from the generated OpenAPI specifications to simplify the public API documentation. These endpoints are typically for internal infrastructure use and don't need to be exposed in client-facing API specs.
- Added
swagger:generatemetadata to exclude health check endpoints from OpenAPI generation - Removed
/livezand/readyzendpoints from all generated OpenAPI files - Cleaned up related error schemas that are no longer needed
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| design/query-svc.go | Added metadata to exclude health check endpoints from Swagger generation |
| gen/http/openapi3.yaml | Removed /livez and /readyz endpoints and unused Error schema |
| gen/http/openapi3.json | Removed health check endpoints from JSON specification |
| gen/http/openapi.yaml | Removed health check endpoints from Swagger 2.0 specification |
| gen/http/openapi.json | Removed health check endpoints from Swagger 2.0 JSON specification |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.