-
Notifications
You must be signed in to change notification settings - Fork 0
feat(helm): add missing environment variables to chart #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add comprehensive environment variable configuration including: - PCC_AUTH0_SECRET for session management - Snowflake analytics configuration (account, credentials, connection pool) - Optional configuration with sensible defaults (LOG_LEVEL, SUPABASE_STORAGE_BUCKET) - Complete documentation in README.md LFXV2-691 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Asitha de Silva <[email protected]>
WalkthroughConfiguration and documentation updates add Snowflake Analytics integration parameters and Auth0 session secret management to the Helm chart. Both README and values.yaml files updated with new environment variables, required fields, and defaults for Snowflake connectivity and optional logging/pooling settings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
🔇 Additional comments (4)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Snowflake analytics configuration and additional Auth0 secrets management to the lfx-v2-ui Helm chart. The changes enable integration with Snowflake for analytics endpoints (active-weeks-streak, pull-requests-merged, code-commits) and add the missing Auth0 session secret configuration.
Key changes:
- Added Snowflake environment variables for analytics integration with both required and optional configuration parameters
- Added
PCC_AUTH0_SECRETfor Auth0 session management - Added
LOG_LEVELconfiguration with a default value of "info"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/lfx-v2-ui/values.yaml | Adds LOG_LEVEL, PCC_AUTH0_SECRET, and comprehensive Snowflake configuration variables (account, credentials, connection pooling) |
| charts/lfx-v2-ui/README.md | Documents the new Snowflake configuration section, updates Auth0 configuration table to include PCC_AUTH0_SECRET, and adds configuration examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Add comprehensive environment variable configuration to the Helm chart including all missing variables required by the application.
Changes
PCC_AUTH0_SECRETfor Auth0 session managementLOG_LEVELandSUPABASE_STORAGE_BUCKETwith defaultsEnvironment Variables Added
Required Secrets
PCC_AUTH0_SECRET- Auth0 session secretSNOWFLAKE_ACCOUNT- Snowflake account identifier (org-account format)SNOWFLAKE_USERNAME- Service user for read-only queriesSNOWFLAKE_ROLE- User role with SELECT-only permissionsSNOWFLAKE_DATABASE- Analytics database nameSNOWFLAKE_WAREHOUSE- Warehouse for query executionSNOWFLAKE_API_KEY- Private key for authenticationOptional Configuration
LOG_LEVEL(default: "info")SUPABASE_STORAGE_BUCKET(default: "meeting-attachments")SNOWFLAKE_LOG_LEVEL(default: "ERROR")SNOWFLAKE_LOCK_STRATEGY(default: "memory")SNOWFLAKE_MIN_CONNECTIONS(default: "2")SNOWFLAKE_MAX_CONNECTIONS(default: "10")Validation
✅ Helm chart lints successfully with no errors
✅ All files formatted with Prettier
✅ Documentation is complete and accurate
✅ Build passes successfully
JIRA Ticket
LFXV2-691
Generated with Claude Code