refactor(meetings): simplify header and fix past meeting access checks

[asithade]

Summary

Refactor header component to simplify UI and fix access control for past meetings.

Related JIRA Ticket

LFXV2-763

Changes Made

Header Component Simplification

• Removed search functionality from header
• Removed persona selector from header
• Removed user profile display from header
• Added max-width container for better layout
• Removed mobile search drawer

Meeting Join Page

• Added header component to meeting-join page for consistent navigation

Past Meeting Access Control Fix

• Added type safety to getMeetings() method with 'meeting' | 'past_meeting' union type
• Fixed access check service to properly handle past meeting resource type
• Added 'past_meeting' to AccessCheckResourceType in shared interfaces

Impact

• Cleaner, simpler header UI across the application
• Consistent header experience on public meeting join pages
• Proper access control validation for past meetings
• Improved type safety in meeting service methods

Files Changed

• apps/lfx-one/src/app/shared/components/header/header.component.html
• apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts
• apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html
• apps/lfx-one/src/server/services/meeting.service.ts
• packages/shared/src/interfaces/access-check.interface.ts

Generated with Claude Code

[coderabbitai]

Walkthrough

The PR adds the header component to the meeting-join page, removes authentication and search UI elements from the header component while adding width constraints, and extends the meeting service type system to support past_meeting resource type with narrowed parameter type safety.

Changes

Cohort / File(s)	Summary
Meeting-join component updates apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html, apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts	Added header component import and template tag to meeting-join module
Header component UI refinement apps/lfx-one/src/app/shared/components/header/header.component.html	Removed user authentication block, persona selector, search autocomplete, and mobile search drawer; added max-w-6xl width constraint
Meeting service type narrowing apps/lfx-one/src/server/services/meeting.service.ts	Narrowed meetingType parameter from string to 'meeting' | 'past_meeting' and updated access check call to pass meetingType variable instead of literal
Shared type extension packages/shared/src/interfaces/access-check.interface.ts	Extended AccessCheckResourceType union to include 'past_meeting'

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that removing authentication/search UI from header doesn't break dependent features or pages using the header
• Confirm meetingType value propagation through the access check service is correct for both 'meeting' and 'past_meeting' cases
• Ensure type narrowing of meetingType parameter doesn't inadvertently break existing callers passing string values

Possibly related PRs

• feat(api): add past-meetings endpoints and frontend integration #78: Directly related—modifies meeting service APIs to propagate 'past_meeting' meetingType with similar access check patterns
• fix(meetings): use direct endpoint calls and fix past meeting display #101: Related—updates meetingType variants and adds past_meeting handling across meeting-related types
• feat(meetings): implement past meeting participant tracking #97: Related—extends meeting service and shared types for past_meeting participant APIs and resource handling

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main objectives: header simplification and past meeting access control fixes.
Description check	✅ Passed	The description clearly relates to the changeset, detailing header refactoring, meeting-join page updates, and access control improvements.
Linked Issues check	✅ Passed	All coding requirements from LFXV2-763 are met: header UI simplified, header added to meeting-join page, type union added to getMeetings, 'past_meeting' added to AccessCheckResourceType.
Out of Scope Changes check	✅ Passed	All changes directly align with LFXV2-763 objectives; no out-of-scope modifications detected in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/LFXV2-763

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 928ab37 and 57048ab.

📒 Files selected for processing (5)

• apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html (1 hunks)
• apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts (2 hunks)
• apps/lfx-one/src/app/shared/components/header/header.component.html (1 hunks)
• apps/lfx-one/src/server/services/meeting.service.ts (2 hunks)
• packages/shared/src/interfaces/access-check.interface.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-10-21T21:19:13.599Z

Learnt from: andrest50
Repo: linuxfoundation/lfx-v2-ui PR: 125
File: apps/lfx-one/src/app/modules/project/meetings/components/meeting-card/meeting-card.component.ts:345-350
Timestamp: 2025-10-21T21:19:13.599Z
Learning: In the Angular meeting card component (apps/lfx-one/src/app/modules/project/meetings/components/meeting-card/meeting-card.component.ts), when selecting between `summary.summary_data.edited_content` and `summary.summary_data.content`, the logical OR operator (`||`) is intentionally used instead of nullish coalescing (`??`) because empty string edited_content should fall back to the original content rather than being displayed as empty.

Applied to files:

• apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html
• apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts

🧬 Code graph analysis (1)

apps/lfx-one/src/server/services/meeting.service.ts (1)

packages/shared/src/interfaces/meeting.interface.ts (1)

• Meeting (90-167)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Upload results

🔇 Additional comments (7)

apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts (1)

11-11: LGTM! Clean integration of HeaderComponent.

The HeaderComponent import and inclusion in the standalone imports array is correct and follows Angular best practices.

Also applies to: 52-52

apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html (1)

3-3: LGTM! Consistent header integration.

Adding the header component to the meeting-join page provides consistent navigation across the application, as intended.

packages/shared/src/interfaces/access-check.interface.ts (1)

35-35: LGTM! Type extension is correct.

The addition of 'past_meeting' to the AccessCheckResourceType union properly supports the enhanced access control for past meetings.

apps/lfx-one/src/app/shared/components/header/header.component.html (2)

5-5: LGTM! Width constraint improves layout.

The max-w-6xl constraint provides better content width control for the header.

---

41-56: LGTM! Simplified authentication UI.

The simplified user menu with avatar and popup menu provides a cleaner interface while maintaining authentication functionality.

apps/lfx-one/src/server/services/meeting.service.ts (2)

79-79: LGTM! Correct access check resource type mapping.

Passing the meetingType variable instead of the hardcoded 'meeting' string correctly enables access control to differentiate between regular meetings and past meetings.

---

54-59: LGTM! Enhanced type safety for meeting types.

The updated signature with meetingType: 'meeting' | 'past_meeting' = 'meeting' provides:

• Strong type safety with the union type
• Backward compatibility with the default value
• Clear intent for the parameter's purpose

Verification confirms all existing callers work correctly:

• past-meeting.controller.ts passes 'past_meeting' as intended
• meeting.controller.ts passes 'meeting' with explicit access control
• No additional call sites require updating

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull Request Overview

This PR refactors the header component UI and fixes access control for past meetings by adding proper type safety and resource type support.

• Simplified header component by removing search functionality, persona selector, and user profile display
• Added type safety to meeting service methods for handling past meetings
• Extended access control to properly validate past meeting resources

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/shared/src/interfaces/access-check.interface.ts	Added 'past_meeting' to AccessCheckResourceType union type
apps/lfx-one/src/server/services/meeting.service.ts	Added type constraint to getMeetings() meetingType parameter and passed it to access check service
apps/lfx-one/src/app/shared/components/header/header.component.html	Removed search UI, persona selector, user profile, and mobile search drawer; added max-width container
apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts	Added HeaderComponent import
apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html	Added header component to meeting join page

Comments suppressed due to low confidence (3)

apps/lfx-one/src/app/shared/components/header/header.component.html:36

• The mobile search toggle button references toggleMobileSearch() but the search functionality and mobile search drawer have been removed from the template. This button should be removed as it would cause an error or unexpected behavior.

            <button
              type="button"
              class="md:hidden hover:opacity-80 transition-opacity p-2"
              (click)="toggleMobileSearch()"
              aria-label="Toggle search"
              data-testid="mobile-search-toggle">
              <i class="fa-light fa-magnifying-glass text-gray-600"></i>
            </button>

apps/lfx-one/src/server/services/meeting.service.ts:88

• The meetingType parameter should use the same type constraint 'meeting' | 'past_meeting' as the getMeetings() method for consistency and type safety.

  public async getMeetingsCount(req: Request, query: Record<string, any> = {}, meetingType: string = 'meeting'): Promise<number> {

apps/lfx-one/src/server/services/meeting.service.ts:102

• The getMeetingById() method hardcodes 'meeting' as the resource type for access checks (line 120), but accepts a meetingType parameter. If a past meeting is requested, the access check will use the wrong resource type. Consider passing the appropriate resource type to the access check or adjusting the parameter to match the access check logic.

  public async getMeetingById(req: Request, meetingUid: string, meetingType: string = 'meetings', access: boolean = true): Promise<Meeting> {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.