feat(meetings): add public meeting registration and RSVP updates by asithade · Pull Request #193 · linuxfoundation/lfx-v2-ui

asithade · 2025-12-03T21:52:51Z

Summary

Add public meeting self-registration for non-invited users on public, non-restricted meetings
Add register button to meeting card and meeting join pages
Add public registration modal component with form validation
Add server endpoint POST /public/api/meetings/register for public meeting registration
Allow users to change their RSVP response after initial selection
Add invited status check to public meeting endpoint for authenticated users
Add meeting helper for user invitation status checks
Fix dashboard section header height alignment (h-8, leading-8)
Add M2M token support for public meeting operations

JIRA Tickets

LFXV2-862 - Public meeting self-registration for non-invited users
LFXV2-863 - Allow users to change their RSVP response
LFXV2-864 - Fix dashboard section header height alignment

🤖 Generated with Claude Code

LFXV2-862 LFXV2-863 LFXV2-864 - Add public meeting self-registration for non-invited users - Add register button to meeting card and meeting join pages - Add public registration modal component - Add server endpoint for public meeting registration - Allow users to change their RSVP response after initial selection - Add invited status check to public meeting endpoint - Add meeting helper for user invitation status - Fix dashboard section header height alignment (h-8, leading-8) - Add M2M token support for public meeting operations Signed-off-by: Asitha de Silva <asithade@gmail.com>

coderabbitai · 2025-12-03T21:53:02Z

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Adds public meeting registration for unauthenticated users, a registration modal, server endpoint and helpers to compute invited status, UI conditionals for register vs RSVP, minor RSVP and styling adjustments, and shared Meeting interface update to include invited: boolean.

Changes

Cohort / File(s)	Change Summary
Styling & Layout `apps/lfx-one/src/app/modules/dashboards/components/my-meetings/my-meetings.component.html`, `apps/lfx-one/src/app/modules/dashboards/components/pending-actions/pending-actions.component.html`, `apps/lfx-one/src/styles.scss`	Minor presentational updates: added header height utilities and a leading-8 line-height for h2.
RSVP UI `apps/lfx-one/src/app/modules/meetings/components/rsvp-button-group/rsvp-button-group.component.html`	Simplified disabled state to only block during loading; removed several non-selected styling variants.
Meeting Card / Join UI `apps/lfx-one/src/app/modules/meetings/components/meeting-card/meeting-card.component.html`, `apps/lfx-one/src/app/modules/meetings/components/meeting-card/meeting-card.component.ts`, `apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html`, `apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts`	Added `isInvited` and `canRegisterForMeeting` computed signals, conditional rendering to show RSVP or Register button, and `registerForMeeting()` to open the public registration dialog; wired refresh trigger to re-fetch meeting after registration.
Public Registration Modal (Client) `apps/lfx-one/src/app/modules/meetings/components/public-registration-modal/public-registration-modal.component.html`, `...public-registration-modal.component.ts`	New standalone modal component with reactive form (first_name, last_name, email, job_title, org_name), validation, submission handler that calls client service and returns registrant on success.
Client Meeting Service `apps/lfx-one/src/app/shared/services/meeting.service.ts`	Added `registerForPublicMeeting()` to POST registrant data to `/public/api/meetings/register`.
Shared Types `packages/shared/src/interfaces/meeting.interface.ts`	Added response-only `invited: boolean` field to `Meeting` interface.
Server: Helpers `apps/lfx-one/src/server/helpers/meeting.helper.ts`	New helpers: `isUserInvitedToMeeting()`, `addInvitedStatusToMeeting()`, `addInvitedStatusToMeetings()` — compute and annotate meetings with `invited` using registrant lookups (M2M token optional).
Server: Meeting Service `apps/lfx-one/src/server/services/meeting.service.ts`	`getMeetingRegistrantsByEmail()` now accepts optional `m2mToken`; added `addMeetingRegistrantWithM2M()` to create registrants using M2M auth — note: method appears declared twice in file.
Server: Controllers `apps/lfx-one/src/server/controllers/meeting.controller.ts`, `apps/lfx-one/src/server/controllers/public-meeting.controller.ts`	Meeting responses enriched with `invited` via helpers; `getMeetingById` and other flows reuse an M2M token where appropriate; new `registerForPublicMeeting()` endpoint implemented in PublicMeetingController that creates a registrant using M2M.
Server: Routes `apps/lfx-one/src/server/routes/public-meetings.route.ts`	Added public POST `/register` route wired to `PublicMeetingController.registerForPublicMeeting()`.
Minor Content `apps/lfx-one/src/app/modules/committees/committee-view/committee-view.component.html`	Link label changed from showing URL to static "Visit" text (href unchanged).

Sequence Diagram(s)

sequenceDiagram
    participant User as User (Unauthenticated)
    participant UI as Meeting UI
    participant Modal as PublicRegistrationModal
    participant Client as Frontend Service
    participant Server as API Server
    participant Service as Meeting Service (microservice)

    User->>UI: View public meeting (not invited)
    UI->>UI: evaluate canRegisterForMeeting
    UI->>User: Show "Register for Meeting" button
    User->>UI: Click Register
    UI->>Modal: Open PublicRegistrationModal
    Modal->>User: Collect form (first_name, last_name, email, ...)
    User->>Modal: Submit form
    Modal->>Client: registerForPublicMeeting(registrantData)
    Client->>Server: POST /public/api/meetings/register
    Server->>Service: addMeetingRegistrantWithM2M(data, m2mToken)
    Service-->>Server: Created MeetingRegistrant
    Server-->>Client: 200 OK (registrant)
    Client->>Modal: Return success
    Modal-->>UI: Close with registrant result
    UI->>UI: Increment registrant count, trigger refresh
    UI->>Server: Fetch updated meeting (may reuse m2mToken)
    Server-->>UI: Updated meeting (includes invited status)

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Pay attention to the duplicate addMeetingRegistrantWithM2M() declaration in apps/lfx-one/src/server/services/meeting.service.ts.
Verify M2M token generation/reuse and expiry handling across public-meeting.controller.ts, meeting.helper.ts, and meeting.service.ts.
Confirm invited computation correctness (email casing, empty email handling, performance for many meetings).
Validate dialog integration and that refreshTrigger$ reliably updates UI state after registration.

Possibly related PRs

refactor(meetings): migrate to global architecture #161 — touches meetings feature and similar meeting-card / meeting-join changes; likely related to invitation/registration UI and flows.

Suggested labels

deploy-preview

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately summarizes the main features: public meeting registration and RSVP updates, matching the core changes in the changeset.
Description check	✅ Passed	The PR description comprehensively relates to the changeset, covering public registration, RSVP updates, dashboard alignment fixes, and M2M token support with JIRA ticket references.
Linked Issues check	✅ Passed	Code changes fully implement LFXV2-862 (public registration with modal, backend endpoint, invited status), LFXV2-863 (RSVP button updates), and LFXV2-864 (dashboard header alignment).
Out of Scope Changes check	✅ Passed	All changes are within scope of the three linked issues. Styling updates (h-8, leading-8), RSVP button modifications, and registration flow additions directly address the stated objectives.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4279af0 and 8193e21.

📒 Files selected for processing (4)

apps/lfx-one/src/app/modules/committees/committee-view/committee-view.component.html (1 hunks)
apps/lfx-one/src/app/modules/meetings/components/meeting-card/meeting-card.component.ts (4 hunks)
apps/lfx-one/src/server/controllers/public-meeting.controller.ts (5 hunks)
apps/lfx-one/src/server/helpers/meeting.helper.ts (1 hunks)

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (7)

packages/shared/src/interfaces/meeting.interface.ts (1)

147-148: Ensure invited is consistently populated across all Meeting responses

invited is added as a required boolean on Meeting but marked “response only”. That’s fine as long as every endpoint (including any that build Meeting objects server-side, and anything extending Meeting like PastMeeting) now sets invited explicitly (e.g., true/false), not by omission.

If there are any Meeting responses that don’t yet add this flag, consider either:

Updating those code paths to always include invited, or

Making the field optional (invited?: boolean) and treating undefined as false in consumers.

This avoids silent divergence between runtime payloads and the shared type.

apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html (1)

160-175: Invited vs register logic on join page looks correct; consider more specific test-id

The new branch:

Shows the RSVP button group only when isInvited() is true.

Falls back to a “Register for Meeting” button when canRegisterForMeeting() is true.

That cleanly matches the intended behavior for invited vs non-invited authenticated users on public, non-restricted meetings.

One minor suggestion: the data-testid="register-meeting-button" used here is also used in the meeting card template. For clearer, less fragile tests, consider a more specific name, e.g. meeting-join-register-meeting-button, and aligning the card’s button similarly.

apps/lfx-one/src/app/modules/meetings/components/meeting-card/meeting-card.component.html (1)

274-295: Meeting card invited/register behavior aligns with new flow; test-id could be more specific

This block correctly:

Shows the RSVP button group only for invited, non-legacy, non-past meetings.

Shows a centered “Register for Meeting” button when canRegisterForMeeting() is true, gated by !pastMeeting() so it doesn’t appear for historical cards.

That matches the public registration requirements and keeps legacy meetings disabled via the existing isLegacyMeeting() flag on the RSVP group.

As with the join template, you may want to rename data-testid="register-meeting-button" to something card-specific (e.g., meeting-card-register-meeting-button) to avoid selector collisions and make tests easier to scope.
apps/lfx-one/src/app/modules/meetings/components/public-registration-modal/public-registration-modal.component.html (1)
48-53: Consider adding validation messages for first_name and last_name fields.

Email validation messages are shown inline, but first_name and last_name (which also have required validators) don't have similar inline validation messages. This creates an inconsistent user experience.

If lfx-input-text doesn't handle validation display internally, consider adding validation messages similar to email:
@if (form.get('first_name')?.errors?.['required'] && form.get('first_name')?.touched && form.get('first_name')?.dirty) {
  <p class="text-sm text-red-500">First name is required</p>
}
apps/lfx-one/src/app/modules/meetings/components/public-registration-modal/public-registration-modal.component.ts (1)
62-103: Submission logic is well-guarded but consider takeUntilDestroyed.

The onSubmit method properly guards against double submission with submitting() check. However, the subscription doesn't unsubscribe on component destruction, which could cause issues if the dialog closes during an in-flight request.

Consider using takeUntilDestroyed or a similar pattern to clean up the subscription:
+import { DestroyRef, inject } from '@angular/core';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';

export class PublicRegistrationModalComponent {
+  private readonly destroyRef = inject(DestroyRef);
   // ... other code

   public onSubmit(): void {
     // ... validation check
     this.meetingService
       .registerForPublicMeeting({...})
+      .pipe(takeUntilDestroyed(this.destroyRef))
       .subscribe({...});
   }
}
apps/lfx-one/src/server/helpers/meeting.helper.ts (1)
20-29: Consider adding structured logging for observability.

Per coding guidelines, backend services should use Pino for structured JSON logs. Adding DEBUG-level logging for the invitation check operation would help with troubleshooting and monitoring.
 export async function isUserInvitedToMeeting(req: Request, meetingUid: string, email: string, m2mToken?: string): Promise<boolean> {
   if (!email || !meetingUid) {
     return false;
   }

   const token = m2mToken || (await generateM2MToken(req));
+  req.log.debug({ operation: 'is_user_invited_to_meeting', meeting_uid: meetingUid }, 'Checking if user is invited to meeting');
   const registrants = await meetingService.getMeetingRegistrantsByEmail(req, meetingUid, email, token);

   return registrants.resources.length > 0;
 }
apps/lfx-one/src/server/services/meeting.service.ts (1)
1249-1286: Minor: Simplify header property syntax.

The implementation is correct. One minor style note: the computed property syntax ['X-Sync'] on line 1261 is unusual when the key is a valid identifier.
-        { Authorization: `Bearer ${m2mToken}`, ['X-Sync']: 'true' }
+        { Authorization: `Bearer ${m2mToken}`, 'X-Sync': 'true' }

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fddfe3d and 4279af0.

📒 Files selected for processing (17)

apps/lfx-one/src/app/modules/dashboards/components/my-meetings/my-meetings.component.html (1 hunks)
apps/lfx-one/src/app/modules/dashboards/components/pending-actions/pending-actions.component.html (1 hunks)
apps/lfx-one/src/app/modules/meetings/components/meeting-card/meeting-card.component.html (1 hunks)
apps/lfx-one/src/app/modules/meetings/components/meeting-card/meeting-card.component.ts (4 hunks)
apps/lfx-one/src/app/modules/meetings/components/public-registration-modal/public-registration-modal.component.html (1 hunks)
apps/lfx-one/src/app/modules/meetings/components/public-registration-modal/public-registration-modal.component.ts (1 hunks)
apps/lfx-one/src/app/modules/meetings/components/rsvp-button-group/rsvp-button-group.component.html (3 hunks)
apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html (1 hunks)
apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts (9 hunks)
apps/lfx-one/src/app/shared/services/meeting.service.ts (1 hunks)
apps/lfx-one/src/server/controllers/meeting.controller.ts (5 hunks)
apps/lfx-one/src/server/controllers/public-meeting.controller.ts (5 hunks)
apps/lfx-one/src/server/helpers/meeting.helper.ts (1 hunks)
apps/lfx-one/src/server/routes/public-meetings.route.ts (1 hunks)
apps/lfx-one/src/server/services/meeting.service.ts (3 hunks)
apps/lfx-one/src/styles.scss (1 hunks)
packages/shared/src/interfaces/meeting.interface.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (9)

**/*.{css,scss}