feat(dashboards): refactor my-projects to use user contribution data by asithade · Pull Request #196 · linuxfoundation/lfx-v2-ui

asithade · 2025-12-04T18:49:45Z

Summary

Refactor my-projects dashboard to fetch user-specific project contributions from USER_PROJECT_CONTRIBUTIONS_DAILY Snowflake table
Remove client-side pagination from my-projects component and add empty state
Fix board member dashboard available accounts binding
Update RSVP disabled message for legacy meetings
Hide data copilot sparkle icon temporarily

Changes

My Projects Component: Remove pagination, add empty state template
Analytics Service/Controller: Remove pagination params, use LF username from OIDC context
User Service: Query USER_PROJECT_CONTRIBUTIONS_DAILY table filtered by LF username
Interfaces: Update UserProjectContributionRow and ProjectItem with new fields

JIRA Tickets

LFXV2-873 - Refactor my-projects to use user contribution data
LFXV2-874 - Fix board member dashboard available accounts binding
LFXV2-875 - Update RSVP disabled message for legacy meetings
LFXV2-876 - Hide data copilot sparkle icon temporarily

- Remove pagination from my-projects component, add empty state - Update analytics service and controller to use LF username - Refactor user service to query USER_PROJECT_CONTRIBUTIONS_DAILY table - Update interfaces with new fields (PROJECT_LOGO, IS_MAINTAINER, AFFILIATION) - Fix board member dashboard available accounts binding (LFXV2-874) - Update RSVP disabled message for legacy meetings (LFXV2-875) - Hide data copilot sparkle icon temporarily (LFXV2-876) LFXV2-873 LFXV2-874 LFXV2-875 LFXV2-876 Signed-off-by: Asitha de Silva <asithade@gmail.com>

coderabbitai · 2025-12-04T18:49:55Z

Walkthrough

This pull request refactors the projects data retrieval from a pagination-based approach to an authentication-based username lookup. It removes lazy-loading pagination from the projects table UI, simplifies the analytics service API, updates backend controllers and services to use authenticated username parameters, and modifies related interface definitions and component properties.

Changes

Cohort / File(s)	Summary
Data Model & Interface Updates `packages/shared/src/interfaces/analytics-data.interface.ts` `packages/shared/src/interfaces/components.interface.ts`	Renamed `UserProjectActivityRow` to `UserProjectContributionRow` with new fields `PROJECT_LOGO` and `IS_MAINTAINER`, removed `DAILY_TOTAL_ACTIVITIES`. Updated `ProjectItem` interface: added `slug` property, changed `role` from string to `'Maintainer' \| 'Contributor'` union type, removed `status` property.
Backend Service Layer Refactoring `apps/lfx-one/src/server/services/user.service.ts` `apps/lfx-one/src/server/controllers/analytics.controller.ts`	Replaced pagination-based query with username-based lookup; refactored `getMyProjects()` signature from `(page, limit)` to `(lfUsername)`. Updated Snowflake query to use CTEs with project logos, affiliations, and activity data filtered by LF username. Removed pagination parameter parsing in controller and added authentication validation.
Frontend Service & API Layer `apps/lfx-one/src/app/shared/services/analytics.service.ts`	Removed pagination parameters from `getMyProjects()` method; now calls `/api/analytics/my-projects` without query params. Updated JSDoc and error fallback response to match new signature.
My Projects Component `apps/lfx-one/src/app/modules/dashboards/components/my-projects/my-projects.component.ts` `apps/lfx-one/src/app/modules/dashboards/components/my-projects/my-projects.component.html`	Removed pagination state (`paginationState$` BehaviorSubject, `onPageChange` method, `rows` signal). Simplified table from lazy-loaded with pagination to direct binding `[value]="projects()"`; added empty state ng-template with "No projects found" message.
Board Member Dashboard `apps/lfx-one/src/app/modules/dashboards/board-member/board-member-dashboard.component.ts` `apps/lfx-one/src/app/modules/dashboards/board-member/board-member-dashboard.component.html`	Changed `availableAccounts` from computed Signal `(this.accountContextService.availableAccounts)` to static array import (`ACCOUNTS`). Updated template binding from method call `availableAccounts()` to property `availableAccounts`.
Minor UI & Text Updates `apps/lfx-one/src/app/modules/meetings/components/meeting-card/meeting-card.component.html` `apps/lfx-one/src/app/shared/components/data-copilot/data-copilot.component.html`	Updated RSVP disabledMessage text from "Meetings created outside of LFX One do not have RSVP functionality" to "RSVP functionality will soon be available for all upcoming LFX meetings visible to you". Commented out sparkle icon in data-copilot button.

Sequence Diagram

sequenceDiagram
    participant Client as Client / Component
    participant Service as Analytics Service
    participant Controller as Analytics Controller
    participant UserSvc as User Service
    participant DB as Snowflake DB

    Client->>Service: getMyProjects()
    Service->>Controller: GET /api/analytics/my-projects
    Controller->>Controller: Extract lfUsername from auth
    alt Username present
        Controller->>UserSvc: getMyProjects(lfUsername)
        UserSvc->>DB: Query projects + affiliations + activities<br/>filtered by LF_USERNAME
        DB-->>UserSvc: Result rows with contribution data
        UserSvc->>UserSvc: Group by PROJECT_ID<br/>Parse affiliations & role
        UserSvc-->>Controller: UserProjectsResponse<br/>(projects[], totalProjects)
        Controller-->>Service: 200 OK + response
    else Username missing
        Controller-->>Service: 401 AuthenticationError
    end
    Service-->>Client: Observable<UserProjectsResponse>
    Client->>Client: Update projects signal

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

user.service.ts: Requires careful review of the Snowflake query refactoring (CTE logic, aggregation, affiliation parsing) and ensure the new username-based filtering returns correct data without introducing regressions
analytics.controller.ts & analytics.service.ts: Verify authentication-based username extraction is secure and that the removal of pagination parameters doesn't break existing API contracts
Interface changes (analytics-data.interface.ts, components.interface.ts): Check that field removals (status), type narrowing (role), and renamings propagate correctly through all consumers
my-projects component: Confirm empty state template displays correctly and that removal of pagination state doesn't leave orphaned references

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: refactoring my-projects to use user contribution data from Snowflake instead of pagination, matching the primary objective.
Description check	✅ Passed	The description is well-related to the changeset, covering all major changes including my-projects refactoring, pagination removal, accounts binding fix, RSVP message update, and data copilot icon hiding.
Linked Issues check	✅ Passed	All coding requirements from linked issues are met: LFXV2-873 refactors my-projects with user contributions and removes pagination LFXV2-873, LFXV2-874 fixes accounts binding [LFXV2-874], LFXV2-875 updates RSVP message [LFXV2-875], and LFXV2-876 hides the sparkle icon [LFXV2-876].
Out of Scope Changes check	✅ Passed	All code changes align with the linked issues: my-projects refactoring, service/controller updates for user contributions, interface updates, accounts binding fix, RSVP message update, and copilot icon visibility change are all within scope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/LFXV2-873

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

apps/lfx-one/src/app/modules/dashboards/components/my-projects/my-projects.component.ts (1)
37-45: Incorrect loading state logic in tap operator.

The tap(() => this.loading.set(true)) executes when the observable emits a value, meaning it sets loading to true after data has arrived. Since loading is already initialized to true on line 25, this tap is both redundant and semantically incorrect.

Apply this diff to fix the loading state flow:
   private readonly projectsResponse = toSignal(
     this.analyticsService.getMyProjects().pipe(
-      tap(() => this.loading.set(true)),
       finalize(() => this.loading.set(false))
     ),
     {
       initialValue: { data: [], totalProjects: 0 },
     }
   );

🧹 Nitpick comments (3)

apps/lfx-one/src/app/modules/meetings/components/meeting-card/meeting-card.component.html (1)

264-272: Consider adding data-testid attributes to RSVP components for better test coverage.

The lfx-meeting-rsvp-details (line 264) and lfx-rsvp-button-group (line 276) components lack data-testid attributes. Given the file's existing convention and the fact that these components now have disabled states and custom messages worth testing, adding identifiers like data-testid="rsvp-details-card" and data-testid="rsvp-button-group" would improve test reliability and consistency with the rest of the component.

Also applies to: 276-281
apps/lfx-one/src/server/services/user.service.ts (2)
382-421: Consider adding a limit for very active users.

The query returns all projects and all daily activity records for a user without any limit. For users with many project contributions over extended periods, this could result in large result sets impacting performance and memory.

Consider adding a date range filter (e.g., last 90 days) or limiting the number of projects returned:
-- In UserProjects CTE, add ORDER BY and LIMIT
ORDER BY PROJECT_NAME, PROJECT_ID
LIMIT 50

-- Or in DailyActivities CTE, add date filter
WHERE LF_USERNAME = ?
  AND ACTIVITY_DATE >= DATEADD(DAY, -90, CURRENT_DATE())
379-379: Missing structured logging per backend service guidelines.

The method lacks logging for operation tracking. Per coding guidelines, backend services should log INFO level for successful data retrieval and DEBUG level for internal operations.

The method needs a req: Request parameter for logging, or use serverLogger directly. Example additions:
public async getMyProjects(req: Request, lfUsername: string): Promise<UserProjectsResponse> {
  req.log.debug({ lfUsername }, 'Fetching user project contributions');
  
  // ... query execution ...
  
  req.log.info(
    { projectCount: projects.length, lfUsername },
    'User project contributions retrieved successfully'
  );
  
  return { data: projects, totalProjects: projects.length };
}
Based on coding guidelines for apps/**/**/server/**/*.{ts,js}.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 22776a1 and bab2101.

📒 Files selected for processing (11)

apps/lfx-one/src/app/modules/dashboards/board-member/board-member-dashboard.component.html (1 hunks)
apps/lfx-one/src/app/modules/dashboards/board-member/board-member-dashboard.component.ts (2 hunks)
apps/lfx-one/src/app/modules/dashboards/components/my-projects/my-projects.component.html (2 hunks)
apps/lfx-one/src/app/modules/dashboards/components/my-projects/my-projects.component.ts (2 hunks)
apps/lfx-one/src/app/modules/meetings/components/meeting-card/meeting-card.component.html (2 hunks)
apps/lfx-one/src/app/shared/components/data-copilot/data-copilot.component.html (1 hunks)
apps/lfx-one/src/app/shared/services/analytics.service.ts (1 hunks)
apps/lfx-one/src/server/controllers/analytics.controller.ts (2 hunks)
apps/lfx-one/src/server/services/user.service.ts (2 hunks)
packages/shared/src/interfaces/analytics-data.interface.ts (2 hunks)
packages/shared/src/interfaces/components.interface.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (8)

**/*.{html,ts,tsx}