feat(meetings): improve meeting join and registration filtering by asithade · Pull Request #198 · linuxfoundation/lfx-v2-ui

asithade · 2025-12-05T18:17:27Z

Summary

Allow authenticated users to join restricted meetings with an alternate email address (LFXV2-885)
Filter all meetings by registration status for the "my meetings" view (LFXV2-886)

Changes

LFXV2-885: Allow authenticated users to join with alternate email

Extract guest form into reusable component (guest-form/)
Add error handling for restricted meeting email validation
Allow authenticated users to enter alternate email when their SSO email is not registered
Prioritize form-submitted email over OIDC user email in backend

LFXV2-886: Filter meetings by registration for my meetings view

Filter ALL meetings (public and private) by registration status
Writers have API access to all meetings for management, but "my meetings" only shows meetings they're registered for
Extract filterMeetingsByRegistration helper method for code reuse

🤖 Generated with Claude Code

LFXV2-885 - Extract guest form into reusable component - Add error handling for restricted meeting email validation - Allow authenticated users to enter alternate email when their SSO email is not registered - Prioritize form-submitted email over OIDC user email in backend 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Asitha de Silva <asithade@gmail.com>

LFXV2-886 - Filter ALL meetings (public and private) by registration status - Writers have API access to all meetings, but my meetings shows only registered - Extract filterMeetingsByRegistration helper method for code reuse - Simplify getUserMeetings by removing writer-specific logic 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Asitha de Silva <asithade@gmail.com>

coderabbitai · 2025-12-05T18:17:37Z

Walkthrough

This PR introduces a guest form component for meeting join flows and refactors authentication/authorization paths. It removes the fallback join button from the dashboard, adds a new guest form component, revamps meeting join logic to support guest workflows, adjusts email handling priority, and refactors user service meeting filtering by registration status.

Changes

Cohort / File(s)	Summary
Guest Form Component `apps/lfx-one/src/app/modules/meetings/components/guest-form/guest-form.component.ts`, `guest-form.component.html`	New standalone component for guest form with form controls (Full Name, Email, Organization), conditional submit button bound to joinUrl(), and form validation wiring. Exports public properties for form, joinUrl, loading state, button visibility, and label customization.
Meeting Join Component (UI) `apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html`	Reworked join/RSVP logic with conditional rendering for direct join, error states, and guest form sections. Replaces inline guest form markup with dedicated lfx-guest-form component. Adds error messaging blocks and OR divider for guest form flow.
Meeting Join Component (Logic) `apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts`	Added guest form workflow with showGuestForm signal, email error handling via initializeEmailError(), and user flow adjustments. Modified auto-join eligibility to skip when guest form active. Changed email form initialization from pre-filled user email to empty. Added onEmailErrorClick() to toggle guest form display.
Dashboard Component `apps/lfx-one/src/app/modules/dashboards/components/dashboard-meeting-card/dashboard-meeting-card.component.html`	Removed else branch providing fallback Join Meeting button with router navigation when direct joinUrl unavailable. Eliminates fallback path; no Join button rendered if joinUrl not available.
Backend Email & Meeting Filtering `apps/lfx-one/src/server/controllers/public-meeting.controller.ts`, `apps/lfx-one/src/server/services/user.service.ts`	Changed email source priority in join URL controller to default to body email before OIDC email. Refactored getUserMeetings to filter all accessible meetings by registration status via new filterMeetingsByRegistration() helper instead of splitting public/private paths.

Sequence Diagrams

sequenceDiagram
    participant User as Guest User
    participant UI as Meeting Join UI
    participant GuestForm as Guest Form Component
    participant Backend as Backend Service
    participant Auth as Join URL Service
    
    User->>UI: Attempts to join meeting (no auth)
    activate UI
    UI->>UI: showGuestForm = true
    UI->>GuestForm: Render guest form
    deactivate UI
    
    User->>GuestForm: Enter name, email, organization
    GuestForm->>GuestForm: Validate form
    
    User->>GuestForm: Click "Join Meeting"
    activate GuestForm
    GuestForm->>Backend: Submit guest info + email
    deactivate GuestForm
    
    activate Backend
    Backend->>Auth: Fetch join URL (guest email source)
    activate Auth
    Auth->>Auth: Check email registration (M2M API)
    Note over Auth: Filters meetings by<br/>registration status
    Auth-->>Backend: Return join URL or error
    deactivate Auth
    
    alt Join URL Available
        Backend-->>GuestForm: joinUrl
        GuestForm->>GuestForm: Open URL in new tab
        GuestForm-->>User: Redirect to meeting
    else Email Not Registered
        Backend-->>UI: joinUrlError (email error)
        UI->>UI: emailError signal = true
        UI->>User: Show error + email action link
        User->>UI: Click email error action
        UI->>GuestForm: Reset and show form again
    end
    deactivate Backend

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

meeting-join.component.ts: Significant logic changes including signal wiring, auto-join flow modifications, and email source reprioritization; requires understanding of new guest form control flow interactions
user.service.ts: Refactored meeting filtering logic introducing new private helper with M2M API calls for registration checks; complexity in async filtering logic and error handling paths
meeting-join.component.html: Substantial template restructuring with multiple conditional branches and new component integration; verify all conditions and bindings are correctly wired
public-meeting.controller.ts: Email source priority inversion may impact existing authenticated flows; verify fallback behavior and error cases

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'feat(meetings): improve meeting join and registration filtering' clearly and concisely summarizes the main changes: adding guest form functionality for alternate email joins (LFXV2-885) and filtering meetings by registration (LFXV2-886).
Description check	✅ Passed	The description accurately describes the changeset, covering both linked issues (LFXV2-885 and LFXV2-886), specific changes made, and implementation details aligned with the PR objectives.
Linked Issues check	✅ Passed	The PR fully addresses both linked issues: LFXV2-885 implements guest form component with email error handling and alternate email submission; LFXV2-886 introduces filterMeetingsByRegistration helper to filter all meetings by registration status.
Out of Scope Changes check	✅ Passed	All changes are within scope of the two linked issues. Minor refactoring in dashboard-meeting-card component (removing else branch) is directly related to the overall join flow improvements.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/LFXV2-885

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (4)

apps/lfx-one/src/server/services/user.service.ts (1)
560-608: Consider consolidating the v parameter.

The query object sets v: 1 (number) on line 564, but DEFAULT_QUERY_PARAMS defines v: '1' (string). Since DEFAULT_QUERY_PARAMS is spread afterward, the string version will override the number, but this creates redundancy. Remove the explicit v: 1 since DEFAULT_QUERY_PARAMS already provides it.
         const query = {
-          v: 1,
           type: 'meeting_registrant',
           parent: `meeting:${meeting.uid}`,
           tags_all: [`email:${email}`],
           ...DEFAULT_QUERY_PARAMS,
         };
apps/lfx-one/src/app/modules/meetings/components/guest-form/guest-form.component.ts (1)
1-3: Add Claude Code attribution comment.

Per the PR description, this code was generated with Claude Code. As per coding guidelines, prepend the attribution comment.
 // Copyright The Linux Foundation and each contributor to LFX.
 // SPDX-License-Identifier: MIT
+// Generated with Claude Code (https://claude.ai/code)
apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts (2)
571-576: Consider using an error code instead of string matching.

Matching error messages by string content is fragile—if the backend message changes, this detection will silently fail. Consider having the backend return a structured error with a stable error code (e.g., EMAIL_NOT_REGISTERED) that you can check reliably.

If the error format cannot be changed, at minimum extract the expected message to a constant to avoid duplication and make updates easier:
+const EMAIL_NOT_REGISTERED_ERROR = 'email address is not registered for this restricted meeting';
+
 private initializeEmailError(): Signal<boolean> {
   return computed(() => {
-    return this.joinUrlError()?.toLowerCase().includes('email address is not registered for this restricted meeting') ?? false;
+    return this.joinUrlError()?.toLowerCase().includes(EMAIL_NOT_REGISTERED_ERROR) ?? false;
   });
 }
1-3: Add Claude Code attribution per coding guidelines.

Per the coding guidelines, files assisted with Claude Code should include an attribution comment. Since the PR description notes this was generated with Claude Code, consider adding:
 // Copyright The Linux Foundation and each contributor to LFX.
 // SPDX-License-Identifier: MIT
+// Generated with Claude Code (https://claude.ai/code)
Based on coding guidelines.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1256a26 and 8d30ddd.

📒 Files selected for processing (7)

apps/lfx-one/src/app/modules/dashboards/components/dashboard-meeting-card/dashboard-meeting-card.component.html (0 hunks)
apps/lfx-one/src/app/modules/meetings/components/guest-form/guest-form.component.html (1 hunks)
apps/lfx-one/src/app/modules/meetings/components/guest-form/guest-form.component.ts (1 hunks)
apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html (3 hunks)
apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts (9 hunks)
apps/lfx-one/src/server/controllers/public-meeting.controller.ts (1 hunks)
apps/lfx-one/src/server/services/user.service.ts (4 hunks)

💤 Files with no reviewable changes (1)

apps/lfx-one/src/app/modules/dashboards/components/dashboard-meeting-card/dashboard-meeting-card.component.html

🧰 Additional context used

📓 Path-based instructions (7)

**/*.{ts,tsx}