fix(eso): remove external secrets key collisions

[agaetep]

Now that we have support for the tags service-pcc: enabled and the passwordless client was renamed, we no longer need the chart to be fixed here. This PR removes that and allows tofu to be the chart's source of truth until the shared helm chart handles it.

[github-actions]

Conventional Commits FTW!

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Removed the dataFrom array from the externalSecrets block in the Helm values file, replacing the previous detailed dataFrom entries (multiple extract and find definitions with rewrites) with an empty list.

Changes

Cohort / File(s)	Summary
Helm configuration charts/lfx-v2-ui/values.yaml	Replaced the previously populated externalSecrets.dataFrom block (which contained multiple extract and find secret query entries with key rewrites) with an empty dataFrom: []. Other externalSecrets fields (provider, target, etc.) were left unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that removed dataFrom secret queries are not required or have been migrated elsewhere.
• Confirm no runtime/service expectations rely on the previously provided Auth0 and pcc secret entries.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title clearly describes the main change: removing external secrets key collisions from the externalSecrets configuration in the values.yaml file.
Description check	✅ Passed	The PR description directly relates to the changeset, explaining the rationale for removing chart-specific fixes to external secrets configuration and the underlying reasons for the change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch agaete/external-secrets

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1aff04a and 33cd6ff.

📒 Files selected for processing (1)

• charts/lfx-v2-ui/values.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• charts/lfx-v2-ui/values.yaml

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR removes the workaround configuration for Auth0 external secrets key collisions from the Helm chart values. With the passwordless client renamed and support for the service-pcc: enabled tag now available, the configuration can be managed through Tofu/Terraform instead of being hard-coded in the chart's values.yaml file.

• Removes the dataFrom section containing Auth0 client secret extraction and rewriting rules
• Eliminates hard-coded references to LFX_ONE and LFX_ONE_Passwordless Auth0 clients
• Removes the service: "pcc" tag-based secret finder with conflict policy

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.