Skip to content

refactor: standardized data refresh#25

Merged
asithade merged 1 commit intofeat/self-permissioningfrom
refactor/data-refresh
Aug 7, 2025
Merged

refactor: standardized data refresh#25
asithade merged 1 commit intofeat/self-permissioningfrom
refactor/data-refresh

Conversation

@asithade
Copy link
Contributor

@asithade asithade commented Aug 6, 2025

  • Convert the way we refresh data for each component to utilize behaviorsubjects

Signed-off-by: Asitha de Silva <asithade@gmail.com>
Copilot AI review requested due to automatic review settings August 6, 2025 19:34
@asithade asithade requested a review from jordane as a code owner August 6, 2025 19:34
@coderabbitai
Copy link

coderabbitai bot commented Aug 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/data-refresh

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors data refresh mechanisms across the application by standardizing the use of BehaviorSubject for triggering data refreshes, replacing previous approaches that relied on navigation-based refresh patterns and injection context management.

Key changes include:

  • Replaced navigation-based refresh patterns with BehaviorSubject-driven refresh mechanisms
  • Simplified component lifecycle by removing manual re-initialization of observables in favor of reactive streams
  • Cleaned up form submission handlers and removed redundant click handlers

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
meeting-dashboard.component.ts Implements BehaviorSubject refresh pattern and removes injection context re-initialization
committee-dashboard.component.ts Replaces navigation-based refresh with BehaviorSubject pattern
committee-view.component.ts Adds BehaviorSubject refresh and combines committee/members data loading
committee-members.component.ts Converts to input-based component removing internal data loading
committee-form.component.* Standardizes method naming and removes redundant click handlers
participant-form.component.html Removes redundant onClick handler from submit button
meeting-form.component.html Removes redundant onClick handler from submit button
member-form.component.html Removes redundant onClick handler from submit button

@asithade asithade merged commit 3cdb5b6 into feat/self-permissioning Aug 7, 2025
4 checks passed
@asithade asithade deleted the refactor/data-refresh branch August 7, 2025 16:35
asithade added a commit that referenced this pull request Aug 7, 2025
* feat: implement complete user permissions management system

- Convert getCommitteeNames function to committee-names.pipe for better performance
- Add permissions matrix component explaining different permission levels and scopes
- Implement edit user functionality with proper form initialization and validation
- Add comprehensive remove user functionality that preserves user records
- Fix backend API to handle permission updates with proper 404 handling
- Move committee names pipe to shared pipes folder for reusability
- Update permission service methods to match backend API contracts
- Ensure proper error handling for all CRUD operations on user permissions

Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: Asitha de Silva <asithade@gmail.com>

* refactor: update language

Signed-off-by: Asitha de Silva <asithade@gmail.com>

* refactor: address pr comments

Signed-off-by: Asitha de Silva <asithade@gmail.com>

* refactor: standardized data refresh (#25)

Signed-off-by: Asitha de Silva <asithade@gmail.com>

* fix: update auth0 algorithm to its default RS256 value

Signed-off-by: Asitha de Silva <asithade@gmail.com>

---------

Signed-off-by: Asitha de Silva <asithade@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants