refactor: standardized data refresh#25
Conversation
asithade
commented
Aug 6, 2025
- Convert the way we refresh data for each component to utilize behaviorsubjects
Signed-off-by: Asitha de Silva <asithade@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors data refresh mechanisms across the application by standardizing the use of BehaviorSubject for triggering data refreshes, replacing previous approaches that relied on navigation-based refresh patterns and injection context management.
Key changes include:
- Replaced navigation-based refresh patterns with BehaviorSubject-driven refresh mechanisms
- Simplified component lifecycle by removing manual re-initialization of observables in favor of reactive streams
- Cleaned up form submission handlers and removed redundant click handlers
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| meeting-dashboard.component.ts | Implements BehaviorSubject refresh pattern and removes injection context re-initialization |
| committee-dashboard.component.ts | Replaces navigation-based refresh with BehaviorSubject pattern |
| committee-view.component.ts | Adds BehaviorSubject refresh and combines committee/members data loading |
| committee-members.component.ts | Converts to input-based component removing internal data loading |
| committee-form.component.* | Standardizes method naming and removes redundant click handlers |
| participant-form.component.html | Removes redundant onClick handler from submit button |
| meeting-form.component.html | Removes redundant onClick handler from submit button |
| member-form.component.html | Removes redundant onClick handler from submit button |
apps/lfx-pcc/src/app/modules/project/committees/committee-view/committee-view.component.ts
Show resolved
Hide resolved
...-pcc/src/app/modules/project/committees/committee-dashboard/committee-dashboard.component.ts
Show resolved
Hide resolved
* feat: implement complete user permissions management system - Convert getCommitteeNames function to committee-names.pipe for better performance - Add permissions matrix component explaining different permission levels and scopes - Implement edit user functionality with proper form initialization and validation - Add comprehensive remove user functionality that preserves user records - Fix backend API to handle permission updates with proper 404 handling - Move committee names pipe to shared pipes folder for reusability - Update permission service methods to match backend API contracts - Ensure proper error handling for all CRUD operations on user permissions Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Asitha de Silva <asithade@gmail.com> * refactor: update language Signed-off-by: Asitha de Silva <asithade@gmail.com> * refactor: address pr comments Signed-off-by: Asitha de Silva <asithade@gmail.com> * refactor: standardized data refresh (#25) Signed-off-by: Asitha de Silva <asithade@gmail.com> * fix: update auth0 algorithm to its default RS256 value Signed-off-by: Asitha de Silva <asithade@gmail.com> --------- Signed-off-by: Asitha de Silva <asithade@gmail.com>