fix(meetings): correct public meeting routes and registration handling

[asithade]

Summary

• Fix meeting route path from /meeting/:id to /meetings/:id for consistency across the application
• Improve committee member registration counting logic to properly calculate individual vs committee registrants
• Add robust error handling for committee enrichment failures to prevent API crashes
• Reduce access check logging verbosity from info to debug level for cleaner logs
• Update documentation to reflect correct route patterns
• Clean up HTML formatting for meeting join buttons

Test plan

• Verify public meeting routes work correctly with new /meetings/:id path
• Test registration counting displays accurate numbers for individual and committee members
• Confirm committee enrichment failures are handled gracefully
• Validate access check logging operates at appropriate debug level
• Check meeting join buttons display properly without formatting issues

Resolves LFXV2-417

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Caution

Review failed

The pull request is closed.

Walkthrough

Updated meeting page route from /meeting/:id to /meetings/:id across client and docs; adjusted return URL computation accordingly. Refactored template buttons to use label attribute. Fixed committee modal status comparison by flattening. Revised registrant counting logic in controller. Added guarded committee enrichment with warnings. Adjusted access-check logging details and level.

Changes

Cohort / File(s)	Summary
Route path rename apps/lfx-pcc/src/app/modules/meeting/meeting.component.ts, docs/architecture/backend/public-meetings.md	Changed route/URL from /meeting/:id to /meetings/:id; updated return URL computation and documentation/middleware examples accordingly.
Template button label usage apps/lfx-pcc/src/app/modules/meeting/meeting.component.html	Rewrote two lfx-button usages to single-line tags using the label attribute instead of inner text; attributes unchanged.
Committee modal voting status comparison apps/lfx-pcc/src/app/modules/project/meetings/components/meeting-committee-modal/meeting-committee-modal.component.ts	Flattened allowed_voting_statuses before comparison; handles undefined entries; no other logic changes.
Registrant counting in controller apps/lfx-pcc/src/server/controllers/meeting.controller.ts	individual_registrants_count now computed as total registrants minus committee members in both list and detail endpoints.
Access-check logging apps/lfx-pcc/src/server/services/access-check.service.ts	Logging moved from info to debug; message text and payload structure changed; no access logic changes.
Committee enrichment resilience apps/lfx-pcc/src/server/services/meeting.service.ts	Wrapped per-committee lookup in try/catch; on failure logs a warning and returns name as undefined instead of aborting.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor C as Client
  participant MS as MeetingService
  participant CS as CommitteeService

  C->>MS: getMeetingCommittees(meetingId)
  loop for each committee_uid
    MS->>CS: fetchCommittee(committee_uid)
    alt success
      CS-->>MS: { uid, name }
      MS->>MS: append { uid, name }
    else failure
      CS-->>MS: throws error
      MS->>MS: log warn {operation, committee_uid, error}
      MS->>MS: append { uid, name: undefined }
    end
  end
  MS-->>C: committees[{ uid, name? }]

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• fix(ui): meeting committee modal fixes #67 — Also modifies MeetingCommitteeModalComponent; overlaps in component behavior around committee data handling.
• feat(permissions): implement role-based permission system #72 — Touches permission/access-check logic; related to AccessCheckService logging and route/permissions context.
• feat(ui): implement registrant modal and BehaviorSubject refresh pattern #64 — Adjusts meeting/registrant domain fields; related to controller changes for registrant counts and meeting responses.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d0cfacc and fdd5164.

📒 Files selected for processing (7)

• apps/lfx-pcc/src/app/modules/meeting/meeting.component.html (2 hunks)
• apps/lfx-pcc/src/app/modules/meeting/meeting.component.ts (1 hunks)
• apps/lfx-pcc/src/app/modules/project/meetings/components/meeting-committee-modal/meeting-committee-modal.component.ts (1 hunks)
• apps/lfx-pcc/src/server/controllers/meeting.controller.ts (2 hunks)
• apps/lfx-pcc/src/server/services/access-check.service.ts (1 hunks)
• apps/lfx-pcc/src/server/services/meeting.service.ts (1 hunks)
• docs/architecture/backend/public-meetings.md (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/LFXV2-417

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull Request Overview

This PR fixes critical meeting route consistency and improves registration counting logic while adding robust error handling for committee operations.

• Fixed public meeting route path from /meeting/:id to /meetings/:id for consistency across the application
• Improved committee member registration counting to properly distinguish individual vs committee registrants
• Added comprehensive error handling for committee enrichment failures to prevent API crashes

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
packages/shared/src/interfaces/meeting.interface.ts	Consolidated meeting committee interfaces and updated field types for consistency
packages/shared/src/constants/meeting.constants.ts	Updated platform values to use proper display names instead of lowercase values
docs/architecture/backend/public-meetings.md	Fixed route documentation to reflect correct /meetings/:id pattern
apps/lfx-pcc/src/server/services/meeting.service.ts	Added committee enrichment logic with robust error handling and improved query filtering
apps/lfx-pcc/src/server/services/access-check.service.ts	Reduced logging verbosity from info to debug level for access checks
apps/lfx-pcc/src/server/controllers/meeting.controller.ts	Fixed registration counting logic to properly calculate individual vs committee registrants
apps/lfx-pcc/src/app/shared/services/meeting.service.ts	Updated query tags to use proper project_uid: prefix format
Multiple frontend components	Updated to use consolidated committees interface and corrected form control names
Multiple test files	Enhanced test coverage with read-only user permissions and improved CI setup

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[github-actions]

🧹 Deployment Removed

The deployment for PR #75 has been removed.

[github-actions]

✅ E2E Tests Passed

Browser: chromium
Status: passed

All E2E tests passed successfully.

Test Configuration

• Node.js: 22
• Command: e2e
• Browser: chromium
• Base URL: http://localhost:4200