Skip to content

Conversation

@Oumph
Copy link
Member

@Oumph Oumph commented Mar 18, 2023

  • missing class to display flag on bookmarks during preview
  • missing flags in some contrib CSS
  • reorder langs in Redis to default to 'xx' (then 'fr', then sorted)

@Oumph Oumph requested a review from Trim March 18, 2023 20:16
Copy link
Member

@Trim Trim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, thanks !

@Trim
Copy link
Member

Trim commented Mar 20, 2023

I'm rebasing the PR #296 with this one and I've just noticed that we also have a list of langs into application.coffee:

langs =
fr: "Français"
de: "Allemand"
en: "Anglais"
eu: "Basque"
ct: "Catalan"
cn: "Chinois"
ko: "Coréen"
da: "Danois"
es: "Espagnol"
ee: "Estonien"
fi: "Finnois"
el: "Grec"
it: "Italien"
ja: "Japonais"
nl: "Néerlandais"
no: "Norvégien"
pl: "Polonais"
pt: "Portugais"
ru: "Russe"
sv: "Suédois"
xx: "!? hmmm ?!"
wq: "Code/binaire"

Maybe you also want to update its order and add missing languages there ?

@Trim
Copy link
Member

Trim commented Mar 20, 2023

I'm rebasing the PR #296 with this one and I've just noticed that we also have a list of langs into application.coffee:

langs =
fr: "Français"
de: "Allemand"
en: "Anglais"
eu: "Basque"
ct: "Catalan"
cn: "Chinois"
ko: "Coréen"
da: "Danois"
es: "Espagnol"
ee: "Estonien"
fi: "Finnois"
el: "Grec"
it: "Italien"
ja: "Japonais"
nl: "Néerlandais"
no: "Norvégien"
pl: "Polonais"
pt: "Portugais"
ru: "Russe"
sv: "Suédois"
xx: "!? hmmm ?!"
wq: "Code/binaire"

Maybe you also want to update its order and add missing languages there ?

Ok, I've found where it's used: when you reorganize a news, there's a Add link button which use JavaScript to directly inject a new web form into the DOM.

So you certainly want to add missing language and reorder them to have same behavior everywhere.

- missing class to display flag on bookmarks during preview
- missing flags in some contrib CSS
- reorder langs in Redis to default to 'xx' (then 'fr', then sorted)
@Oumph Oumph force-pushed the fix_link_preview branch from 8f1294c to 003877e Compare March 22, 2023 19:24
@Oumph Oumph merged commit 75fe527 into master Mar 22, 2023
@Oumph Oumph deleted the fix_link_preview branch March 22, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants