-
Notifications
You must be signed in to change notification settings - Fork 54
Rails8 #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
echarp
wants to merge
88
commits into
linuxfrorg:rails7
Choose a base branch
from
echarp:rails8
base: rails7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rails8 #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dépendant de la gemme rails-sass-images qui n'est plus développée
l'évolution de la gemme
Ajout de "optional: true" pour les modèles qui permettent une valeur "null". Document du comportement belongs_to: https://sipsandbits.com/2015/09/21/whats-new-in-rails-5/#belongs_toisrequiredbydefault
Il y avait deux classes pour dynamiquement chercher des templates entre les espaces de rédaction et modération, après tests et recherches il semble que ça ne soit pas (ou plus?) nécessaire.
les espaces de rédaction et modération
Tests et validations nécessaires, mais en pause car migration vers 7 prévue
…s non fonctionnelles
La méthode est maintenant nommée File.exist?
qui sont à peu près touts couverts
(en tous cas du code testé d'après la gemme simplecov...)
(semble non utilisé dans l'IHM)
Il pourrait y avoir d'autres cas, cela vient de la simplification de recherche des chemins de partiaux, suite (ou grâce) à la migration à rails 7
Il manque les contrôleurs d'API dans cette couverture...
La nouvelle version supprime quelques helper, dont `list_of` qui était utilisée ici et là et qui est maintenant rajoutée dans `application_helper`. Méthodes supprimées: block_is_haml?, capture_haml, escape_once, find_and_preserve, flatten, haml_concat, haml_indent, haml_tag, haml_tag_if, html_attrs, html_escape, init_haml_helpers, is_haml?, list_of, non_haml, precede, succeed, surround, tab_down, tab_up, with_tabs Référence: https://github.com/haml/haml/releases/tag/v6.0.0
Still maintained, will require an upgrade to dart-sass at some point.
Upgrade haml and sass
This commit updates several gem dependencies in the Gemfile and Gemfile.lock, including Rails and related gems. The version constraint for the sitemap_generator gem has been removed, allowing the latest version to be used. The sitemap configuration has been updated to match the new usage of sitemap_generator. The encoding comment and an extra line have been removed, and the `add_links` method has been replaced with `create`. Extra lines have been added before `sitemap.add` calls for readability.
feat: Update gem dependencies and sitemap generator
This commit introduces two new global constants MY_PUBLIC_URL and IMG_PUBLIC_URL which should be used now to build URLs. For alpha and production Ruby environments, they are fixed with their real values directly in the `config/environments/*.rb` files. For the development Ruby environment, they are defined by default to `http://dlfp.lo` and `http://image.dlfp.lo`. You can customize either by updating the `config/environments/development.rb` file or by setting the *process* environment variables `DOMAIN`, `DOMAIN_HTTP_PORT`, `IMAGE_DOMAIN` and `IMAGE_DOMAIN_HTTP_PORT`. For containers, you can set these variables in the `deployment/default.env` file.
allow to use custom HTTP public port to permit rootless run
This commit introduces two new global constants MY_PUBLIC_URL and IMG_PUBLIC_URL which should be used now to build URLs. For alpha and production Ruby environments, they are fixed with their real values directly in the `config/environments/*.rb` files. For the development Ruby environment, they are defined by default to `http://dlfp.lo` and `http://image.dlfp.lo`. You can customize either by updating the `config/environments/development.rb` file or by setting the *process* environment variables `DOMAIN`, `DOMAIN_HTTP_PORT`, `IMAGE_DOMAIN` and `IMAGE_DOMAIN_HTTP_PORT`. For containers, you can set these variables in the `deployment/default.env` file.
- Upgraded Rails from 7.1 to 7.2 in Gemfile and related files. - Updated config/initializers/secrets.rb to load secrets from environment variables if present, falling back to credentials if not. - Ensured that `secret_key_base`, `push_secret`, and `devise_pepper` are loaded securely. - Updated config/secrets.yml.sample to reflect the changes.
- Target Debian Trixie (stable) - Update MySQL/MariaDB package names - Simplify Bundler installation (now included with Ruby) - Improve document structure and add syntax highlighting
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.