Improve error handling in Pihole app #816
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey @kroese you had linter issues so I merged the other pihole pr first, causing some merge conflicts for you, sorry. |
Contributor
Author
|
@mvdkleijn I created a new pull: #818 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the wrong password for the API, the app fails to parse the response and just fails with the generic error message "Server error". This made it very hard for me to pinpoint the problem, because if the URL is invalid for example you will get an identical response.
So I improved the error handling when communicating with the API, and now it communicates the correct error message back to the user, for example "invalid password".