Allow spaces in extensions list #968
Closed
rvenutolo wants to merge 2 commits intolinuxserver:code-server-extension-argumentsfrom
Closed
Allow spaces in extensions list #968rvenutolo wants to merge 2 commits intolinuxserver:code-server-extension-argumentsfrom
rvenutolo wants to merge 2 commits intolinuxserver:code-server-extension-argumentsfrom
Conversation
This a convenience to allows for spaces. Ex: `vscode-icons-team.vscode-icons | ms-azuretools.vscode-docker`. Signed-off-by: Rick Venutolo <rvenutolo@users.noreply.github.com>
Signed-off-by: Rick Venutolo <rvenutolo@users.noreply.github.com>
|
PR build pushed to |
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request is locked due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently, handling the
VSCODE_EXTENSION_IDSenvironment variable does not allow for spaces in the string. This change strips all spaces from that variable before it is used to install extensions.The
VSCODE_EXTENSION_IDShandling will be more flexible to allow spaces and thus allowVSCODE_EXTENSION_IDSdeclarations like the following in Docker compose file:or nicer mult-line strings when one has numerous extensions.
Benefits of this PR and context:
This allows the user to include spaces in the
VSCODE_EXTENSION_IDSvalue, which can improve readability in Docker compose files.How Has This Been Tested?
I replaced the existing
/etc/s6-overlay/s6-rc.d/init-mod-code-server-extension-arguments/runfile with my updated version.I ran
docker compose upwith each of the followingVSCODE_EXTENSION_IDSdefinitions in the compose file. I then looked at the logging to check that the extension IDs were processed as desired.Source / References:
N/A