Update dashboard.subdomain.conf.sample#976
Closed
hellblazer315 wants to merge 1 commit intolinuxserver:swag-dashboardfrom
Closed
Update dashboard.subdomain.conf.sample#976hellblazer315 wants to merge 1 commit intolinuxserver:swag-dashboardfrom
hellblazer315 wants to merge 1 commit intolinuxserver:swag-dashboardfrom
Conversation
Changed from explicit IP ranges to using an included config file. Recommend this shouldn't be merged upstream unless linuxserver/docker-swag#520 is as well. Signed-off-by: hellblazer315 <78935529+hellblazer315@users.noreply.github.com>
|
PR build pushed to |
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Member
|
As we've discussed on discord, this will break backward compatibility with older versions of swag. |
|
This pull request is locked due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed from explicit IP ranges to using an included config file. Recommend this shouldn't be merged upstream unless linuxserver/docker-swag#520 is as well.
Description:
Removed all explicit IP Address ranges and instead added an include to a static config file.
Dependency: Requires an internal.conf file as proposed by linuxserver/docker-swag#520
Benefits of this PR and context:
Allows a single place to manage IPs instead of 3 different places in the file. Also allows easier re-use of this configuration in other proxy configs.
How Has This Been Tested?
Created the internal.conf from linuxserver/docker-swag#520 then removed all IP blocks in dashboard.subdomain.conf and replaced with "include /config/nginx/internal.conf". Confirmed access is still restricted to local IPs.
Source / References:
linuxserver/docker-swag#520