github: Remove redundant meson build option#860
Merged
whot merged 1 commit intolinuxwacom:masterfrom Feb 24, 2025
AesaraB:master
Merged
github: Remove redundant meson build option#860whot merged 1 commit intolinuxwacom:masterfrom AesaraB:master
whot merged 1 commit intolinuxwacom:masterfrom
AesaraB:master
Conversation
whot
reviewed
Feb 23, 2025
Contributor
Author
|
Tests passed, ready for review |
Contributor
Author
|
Tests are using the appropriate compiler still |
Contributor
Author
|
I may however change the name of the commit to reflect the removal of the compiler options altogether |
The issue referred to in the clang compiler workaround has since been closed. mesonbuild/meson#764 Closes #859 Signed-off-by: Aesara Binder <aesara@mailbox.org>
whot
approved these changes
Feb 24, 2025
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #859
Peter wanted to see if the CI fails after excising some code.
However, I am not very familiar with GitHub CI, so I can't say whether the CI will use the clang compiler (for which the workaround was provisioned).