Skip to content

Support "AliasOf" keyword #871

Merged
whot merged 2 commits intolinuxwacom:masterfrom
whot:wip/aliasof
Mar 21, 2025
Merged

Support "AliasOf" keyword #871
whot merged 2 commits intolinuxwacom:masterfrom
whot:wip/aliasof

Conversation

@whot
Copy link
Member

@whot whot commented Mar 18, 2025

Add a new keyword to libwacom.stylus so we can share the settings among those tools that of the same type.

This supersedes #844 and has the various missing bits:

  • style changes and memleak fixes
  • better error path handling through g_set_error()
  • support for full stylus ids (vid:pid format)
  • test case added so we can make sure the overrides actually works

Closes #761

Closes #884

@whot whot requested a review from skomra March 18, 2025 03:56
@skomra skomra mentioned this pull request Mar 18, 2025
Copy link
Member

@skomra skomra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Erin Skomra erin.skomra@wacom.com

skomra added 2 commits March 21, 2025 11:20
Share settings among those tools that of the same type.

Closes linuxwacom#761
Add AliasOf keyword to ISDV4/AES devices, these are all effectively all
the same device.
@whot
Copy link
Member Author

whot commented Mar 21, 2025

Added another test for invalid aliases which showed up a missing continue in an error case. Fixed now so this should be ready to go.

@whot whot added this pull request to the merge queue Mar 21, 2025
Merged via the queue into linuxwacom:master with commit b32739f Mar 21, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: stylus tool id aliases

2 participants