fix: assign new sequence number for Split() parts > 1#179
Open
sboli wants to merge 6 commits intolinxGnu:masterfrom
Open
fix: assign new sequence number for Split() parts > 1#179sboli wants to merge 6 commits intolinxGnu:masterfrom
sboli wants to merge 6 commits intolinxGnu:masterfrom
Conversation
Owner
|
@laduchesneau PTAL. Basically, it's LGTM |
Owner
|
@sboli could you please write an unit test. |
Collaborator
|
The code is simple and looks go to me, but I also agree that a small a unit test is needed. |
Collaborator
|
If you want, you can add a new const call SM_GSM_MSG_LEN_7BIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When sending a concatenated message, all the splits had the same sequence number. This prevents reconciliation of the message ID using the sequence number return in submit_sm_resp
Fix
Call AssignSequenceNumber when splitting, if we have more than 1 part.