feat: makes getting concat info work for 16-bit reference#186
Open
gomaja wants to merge 3 commits intolinxGnu:masterfrom
Open
feat: makes getting concat info work for 16-bit reference#186gomaja wants to merge 3 commits intolinxGnu:masterfrom
gomaja wants to merge 3 commits intolinxGnu:masterfrom
Conversation
gomaja
force-pushed
the
features-getting-concat-info-for-16-bit-reference
branch
from
f799d21 to
39b0cf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a PR that returns appropriate concatenated info when using a 16-bit reference.
I also suggest making the fields totalParts and partNum as uint instead of byte. Please let me know in case.