feat: Add screenshot tests for topographic-v2 maps. BM-1356#432
Merged
tawera-manaena merged 4 commits intomasterfrom Oct 20, 2025
Merged
feat: Add screenshot tests for topographic-v2 maps. BM-1356#432tawera-manaena merged 4 commits intomasterfrom
tawera-manaena merged 4 commits intomasterfrom
Conversation
3697189 to
95da6ac
Compare
tawera-manaena
approved these changes
Oct 9, 2025
Contributor
|
Important Changes - @linz/proj-basemaps
|
ccbblin
approved these changes
Oct 20, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
🤖 I have created a release *beep* *boop* --- ## [1.10.0](v1.9.0...v1.10.0) (2025-10-20) ### Features * add screenshot tests for the topo-raster tileset BM-1167 ([#424](#424)) ([5acff1e](5acff1e)) * Add screenshot tests for topographic-v2 maps. BM-1356 ([#432](#432)) ([f34db3b](f34db3b)) * add the topographic tests used to validate the Shortbread vector maps BM-1198 ([#428](#428)) ([cfe2b88](cfe2b88)) * Update screenshot to compare diffs between two URLs. BM-1202 ([#426](#426)) ([c78eb70](c78eb70)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: linz-li-bot <134554979+linz-li-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Update all the topographic tests to point to topgraphic-v2 data now.
And only kept four old topographic tests as we will stop supporting them soon.
Modifications
Refactored all
topographicbasemap tests to referencetopographic-v2instead.Copied a select few of the existing
topographictests to the end of the test list.Grouped similar tests under heading, such as:
Added detail to non-descriptive names, such as:
topographic-v2-3857-z8topographic-v2-3857-north-island-z8Referenced test locations by constants, such as:
location: { lat: -41.8899962, lng: 174.0492437, z: 5 },location: { ...Locs.Mainland, z: 5 },Verification