Skip to content

feat: Add screenshot tests for topographic-v2 maps. BM-1356#432

Merged
tawera-manaena merged 4 commits intomasterfrom
feat/topographic-v2-test
Oct 20, 2025
Merged

feat: Add screenshot tests for topographic-v2 maps. BM-1356#432
tawera-manaena merged 4 commits intomasterfrom
feat/topographic-v2-test

Conversation

@Wentao-Kuang
Copy link
Copy Markdown
Contributor

@Wentao-Kuang Wentao-Kuang commented Oct 6, 2025

Motivation

Update all the topographic tests to point to topgraphic-v2 data now.
And only kept four old topographic tests as we will stop supporting them soon.

Modifications

  • Refactored all topographic basemap tests to reference topographic-v2 instead.

  • Copied a select few of the existing topographic tests to the end of the test list.

  • Grouped similar tests under heading, such as:

    /**
     * topographic-v2: north island
     */
    
  • Added detail to non-descriptive names, such as:

    Before After
    topographic-v2-3857-z8 topographic-v2-3857-north-island-z8
  • Referenced test locations by constants, such as:

    Before After
    location: { lat: -41.8899962, lng: 174.0492437, z: 5 }, location: { ...Locs.Mainland, z: 5 },

Verification

@Wentao-Kuang Wentao-Kuang force-pushed the feat/topographic-v2-test branch from 3697189 to 95da6ac Compare October 9, 2025 22:14
@tawera-manaena
Copy link
Copy Markdown
Contributor

tawera-manaena commented Oct 13, 2025

Important Changes - @linz/proj-basemaps

  • Many of our tests point to similar locations, but not exact. We've consolidated such locations to point to the exact same location, referenced by variable (e.g. Locs.Mainland). This means that, once this work merges, some tests will look overwhelmingly red as they point to slightly different locations. This will only occur the first time.
  • We've also modified the names of existing tests to be more descriptive (e.g. health-3857-z5 to health-3857-mainland-z5). This means that such tests will appear as_new_ tests. Similarly, this will only occur the first time.

@tawera-manaena tawera-manaena added this pull request to the merge queue Oct 20, 2025
Merged via the queue into master with commit f34db3b Oct 20, 2025
5 of 6 checks passed
@tawera-manaena tawera-manaena deleted the feat/topographic-v2-test branch October 20, 2025 23:37
github-merge-queue bot pushed a commit that referenced this pull request Oct 20, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.10.0](v1.9.0...v1.10.0)
(2025-10-20)


### Features

* add screenshot tests for the topo-raster tileset BM-1167
([#424](#424))
([5acff1e](5acff1e))
* Add screenshot tests for topographic-v2 maps. BM-1356
([#432](#432))
([f34db3b](f34db3b))
* add the topographic tests used to validate the Shortbread vector maps
BM-1198 ([#428](#428))
([cfe2b88](cfe2b88))
* Update screenshot to compare diffs between two URLs. BM-1202
([#426](#426))
([c78eb70](c78eb70))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: linz-li-bot <134554979+linz-li-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants