Conversation
|
@linz/proj-basemaps-dev - A unit test for this would be great. It looks like the unzipping logic lives within the ingest function - which does a lot of other work. Any concerns about isolating the unzipping logic into a standalone function so we can target it via unit tests? |
|
@linz/proj-basemaps-dev - Looks like we used to use unzip-stream (commit), which is a fork of unzipper. The commit suggests we switched to fflate to resolve some reading bugs. Not sure if we'll run into those reading bugs again or if they've since been resolved dependency-side. |
ccbblin
requested review from
Wentao-Kuang and
tawera-manaena
and removed request for
a team
It's a long time ago but do you remember what the reading bugs were @blacha |
🤖 I have created a release *beep* *boop* --- ## [0.3.1](v0.3.0...v0.3.1) (2025-09-25) ### Bug Fixes * alternative unzipping lib ([#1060](#1060)) ([4f0c250](4f0c250)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
3 participants
Motivation
alternative unzipping library, needs some more testing