feat(topographic-system): Update the map produce workflow to use stac-push. BM-1624#1188
Open
Wentao-Kuang wants to merge 1 commit intomasterfrom
Open
feat(topographic-system): Update the map produce workflow to use stac-push. BM-1624#1188Wentao-Kuang wants to merge 1 commit intomasterfrom
Wentao-Kuang wants to merge 1 commit intomasterfrom
Conversation
blacha
reviewed
Apr 14, 2026
| - name: cover-items | ||
| path: /tmp/produce/cover-items.json | ||
| container: | ||
| image: 725496895483.dkr.ecr.ap-southeast-2.amazonaws.com/github/linz/topographic-system/map:{{ inputs.parameters.version_map_cli }} |
Member
There was a problem hiding this comment.
We should be using the github pull through cache if we can.
blacha
reviewed
Apr 14, 2026
| --target={{ inputs.parameters.target }} \ | ||
| --category=product \ | ||
| --strategy=date \ | ||
| $( [ "{{ inputs.parameters.latest }}" = "true" ] && echo "--strategy=latest" ) \ |
Member
There was a problem hiding this comment.
It would be best if we could use sprig to format the args so we can avoid the bash -c
Im not entirely sure what the sprig logic looks like but hopefully something like
{{= inputs.parameters.latest == "true" ? "--strategy=latest" : "" }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We are not ready to use stac-push for the map produce workflow.
Modifications
map-produceworkflow to use the stac-push cmd instead of copy, so that we can have the strategy included and upsert the catalogs.sheet-produceworkflow, which is same asmap-produceworkflow when setproduce_all=falseVerification
https://argo.linzaccess.com/workflows/argo/test-topographic-map-produce-wentao-pr-119-zq74b?tab=workflow&nodeId=test-topographic-map-produce-wentao-pr-119-zq74b-1921968635&nodePanelView=containers&uid=e4fe5e49-5727-4c0e-acf7-50e7133c3d13