Added bootstrap 4 support, added new icons, cleaned up docs#162
Added bootstrap 4 support, added new icons, cleaned up docs#162niftylettuce wants to merge 5 commits intolipis:gh-pagesfrom
Conversation
| .btn-yahoo { @include btn-social(#720e9e); } | ||
| // bootstrap-social support for bootstrap 4.x | ||
| // <https://github.com/lipis/bootstrap-social/issues/123> | ||
| @import '_custom'; |
There was a problem hiding this comment.
Imported partial _custom should be written as custom
Prefer double-quoted strings
| // bootstrap | ||
| @import 'node_modules/bootstrap/scss/_functions'; | ||
| @import 'node_modules/bootstrap/scss/_mixins'; | ||
| @import 'node_modules/bootstrap/scss/_variables'; |
There was a problem hiding this comment.
Imported partial node_modules/bootstrap/scss/_variables should be written as node_modules/bootstrap/scss/variables
Prefer double-quoted strings
| $bs-height-xs: (floor($font-size-small * 1.2) + $padding-small-vertical + 1) !default; | ||
| // bootstrap | ||
| @import 'node_modules/bootstrap/scss/_functions'; | ||
| @import 'node_modules/bootstrap/scss/_mixins'; |
There was a problem hiding this comment.
Imported partial node_modules/bootstrap/scss/_mixins should be written as node_modules/bootstrap/scss/mixins
Prefer double-quoted strings
| $bs-height-sm: (floor($font-size-small * 1.5) + $padding-small-vertical * 2) !default; | ||
| $bs-height-xs: (floor($font-size-small * 1.2) + $padding-small-vertical + 1) !default; | ||
| // bootstrap | ||
| @import 'node_modules/bootstrap/scss/_functions'; |
There was a problem hiding this comment.
Imported partial node_modules/bootstrap/scss/_functions should be written as node_modules/bootstrap/scss/functions
Prefer double-quoted strings
| } | ||
|
|
||
| .btn-whatsapp { | ||
| @include btn-social(#25D366, #fff); |
There was a problem hiding this comment.
Color literals like #25D366 should only be used in variable declarations; they should be referred to via variable everywhere else.
Color #25D366 should be written as #25d366
Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
|
|
||
| .btn-vk { | ||
| @include btn-social(#587ea3); |
There was a problem hiding this comment.
Color literals like #587ea3 should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
|
|
||
| .btn-vimeo { | ||
| @include btn-social(#1ab7ea); |
There was a problem hiding this comment.
Color literals like #1ab7ea should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
|
|
||
| .btn-twitter { | ||
| @include btn-social(#1DA1F2, #fff); |
There was a problem hiding this comment.
Color literals like #1DA1F2 should only be used in variable declarations; they should be referred to via variable everywhere else.
Color #1DA1F2 should be written as #1da1f2
Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
|
|
||
| .btn-tumblr { | ||
| @include btn-social(#2c4762); |
There was a problem hiding this comment.
Color literals like #2c4762 should only be used in variable declarations; they should be referred to via variable everywhere else.
| } | ||
|
|
||
| .btn-soundcloud { | ||
| @include btn-social(#ff5500); |
There was a problem hiding this comment.
Color literals like #ff5500 should only be used in variable declarations; they should be referred to via variable everywhere else.
|
@lipis is there anything holding this PR from being merged? |
|
I've published my own version due to no activity from @lipis. If anyone is interested in using my fork, you can The repository is at https://github.com/ladjs/bootstrap-social and latest version on npm is 7.0.0. |
|
hey guys.. sorry for being inactive for quite some time.. I'll try to figure out what is going on with version 4 and I'll try to revive this project :) |
|
@lipis ping me if you need a hand. Thx! |
|
Bump? |
| [Font Awesome](http://fortawesome.github.io/Font-Awesome/)! | ||
|
|
||
| [Check the live demo!](http://lipis.github.io/bootstrap-social) | ||
| [Check the live demo!](http://niftylettuce.com/bootstrap-social/) |
7 participants
No description provided.