Dockerfile enhancements #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update apt-get command to perform cleanup, shrinks existing image by about 20MB Use ARG instead of ENV for LIQUIBASE_VERSION. This enables you to pass the Liquibase version at image build time and create tagged builds easily. Also avoids setting an extra env variable during docker run. Example tagged build command: docker build . --build-arg LIQUIBASE_VERSION=3.8.5 -t liquibase/docker:3.8.5 Simplify download logic and avoid the intermediate file Use chmod safely (755 vs 777)
Contributor
|
DM me your address and we'll send you a Liquibase T-shirt!!! You can also DM @liquibase on Twitter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update apt-get command to perform cleanup, shrinks existing image by about 20MB
Use ARG instead of ENV for LIQUIBASE_VERSION. This enables you to pass the Liquibase
version at image build time and create tagged builds easily. Also avoids setting
an extra env variable during docker run. Example tagged build command:
docker build . --build-arg LIQUIBASE_VERSION=3.8.5 -t liquibase/docker:3.8.5
Simplify download logic and avoid the intermediate file
Use chmod safely (755 vs 777)