-
Notifications
You must be signed in to change notification settings - Fork 10
BYOV Exit Flow (BS-2454) #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 51 commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
8c2d784
feat(byov): add allocation-based validator deposit with strict valida…
juliaaschmidt ca84d0e
chore: tidy up OperatorsRegistry tests for allocations
juliaaschmidt 140ecb4
feat(deposits): add allocation ordering validation and optimize depos…
juliaaschmidt 6f8430b
fix: revert NotEnoughFunds implementation changes + expectation of tests
juliaaschmidt c6ef4a6
style: consistent looping
juliaaschmidt 8c0b55d
fix: natspec comment
juliaaschmidt 9425654
test(deposits): add test for faulty registry returning fewer keys
juliaaschmidt 7c20687
test(deposits): add test for allocation exceeding committed balance
juliaaschmidt 69191ed
style: natspec changes
juliaaschmidt d286f80
chore: first draft
iamsahu a097680
fix: ConsensusLayerDepositManager tests
juliaaschmidt 8ac80b1
style: forge fmt
juliaaschmidt 4190d3e
test(deposits): add test for faulty registry returning more keys than…
juliaaschmidt 79a945b
style: refactor allocation test helper to avoid duplication
juliaaschmidt 618bd55
style: rm comment + rename helper for consistency
juliaaschmidt 2577c48
feat: add more unit tests for pickNextValidatorsToDepositFromActiveOp…
juliaaschmidt 5250225
chore: test fix
iamsahu 486b172
test(consensus-layer-deposit): add allocation validation tests
juliaaschmidt 23024db
test(operators-registry): add allocation validation error tests
juliaaschmidt cbb5293
style: forge fmt
juliaaschmidt 2145d63
test(operators-registry): add test for zero fundable operators case
juliaaschmidt 8e719c7
test(operators-registry): add branch coverage for operator lookup loop
juliaaschmidt dd689b5
feat: add another OR test to improve % coverage change
juliaaschmidt 569e8d6
test(operators-registry): add coverage for inactive operator with mul…
juliaaschmidt 179a9d7
review: test fix make more robust
juliaaschmidt 8164b6d
style: rm duplicate test
juliaaschmidt fbc3cea
test(operators-registry): increase test coverage for OperatorsRegistr…
juliaaschmidt 850e4a3
fix: forge fmt
juliaaschmidt cff3955
feat: add Operators.1.t.sol to increase cov
juliaaschmidt bb3d3f8
fix: unintended change
juliaaschmidt e3b06a3
chore: tests added for coverage
iamsahu a5836a0
chore: tests fixed
iamsahu 74901b4
chore: coverage complete
iamsahu 476c980
chore: test additions
iamsahu d7ec64f
chore: fix merge conflicts
iamsahu 262a423
chore: fixed tests
iamsahu 1474ee7
fix: Certora Prover Verifier Rules To Match New Function Signatures (…
juliaaschmidt 5ed6327
Merge branch 'feat/byov-v1-clean' into feat/byov-v1-exit
iamsahu dbdc2b2
chore: test coverage
iamsahu 9f56695
chore: removed unused code from OperatorsV2
iamsahu b20b8de
chore: check for 0 allocation
iamsahu 1590ef2
chore: fix test
iamsahu 00c3696
Merge branch 'main' into feat/byov-v1-clean
juliaaschmidt 4128357
fix: update solc version Operators.1.t.sol
juliaaschmidt e21a489
bugfix: bump prover RedeemManagerV1.conf solc to 0.8.33
juliaaschmidt e374dec
bug-fix: add JDK version 21 to Certora.yaml
juliaaschmidt edfe6bb
bugfix: remove solc optimizer step
juliaaschmidt 4b84520
chore: suggestions
iamsahu 99653ea
Merge branch 'feat/byov-v1-clean' into feat/byov-v1-exit
iamsahu 2d9ae64
chore: more suggestions
iamsahu a1278bb
chore: correction in error naming
iamsahu 5c7e4b2
feat: external test helper (review suggestion)
juliaaschmidt 292f26f
style: refactor test helpers to external Test Base (review suggestion)
juliaaschmidt 8800197
chore: review suggestions
iamsahu 75d6c4b
chore: review suggestions
iamsahu 19c9f43
fix(OperatorsRegistry) prover fix
juliaaschmidt f03415a
chore: certora rule correction
iamsahu bfa5892
chore: certora rule correction
iamsahu ca28d0e
Merge branch 'feat/byov-v1-clean' into feat/byov-v1-exit
iamsahu 9cf1690
chore: certora CI change
iamsahu 24a9c2c
This adds in some more tests :
mischat 9a108fb
This adds in some more tests :
mischat 9d0ba9f
Merge branch 'main' into feat/byov-v1-exit
iamsahu bd14cbf
Merge branch 'feat/byov-v1-exit' of https://github.com/liquid-collect…
iamsahu 0aa3f1d
chore: fix certora
iamsahu 076fb98
chore: fix certora spec
iamsahu 35cd977
chore: coverage increase
iamsahu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserved
requestValidatorExitsshould reflect the non‑empty precondition.The implementation rejects empty allocations; preserved blocks that allow length 0 can model impossible calls and weaken the invariants.
🛠️ Suggested fix (apply to all preserved `requestValidatorExits` blocks)
Also applies to: 206-207, 213-214, 395-396, 787-788
🤖 Prompt for AI Agents