Add sorted list info to getters in BribeInitiative#129
Merged
Conversation
danielattilasimon
approved these changes
Jul 7, 2025
Contributor
danielattilasimon
left a comment
danielattilasimon
left a comment
There was a problem hiding this comment.
Yes, this is pretty much all that we're missing!
Just to be extra sure, I'd like to rewrite the claiming logic in BribeInitiativeFireAndForget.t.sol to rely solely on publicly readable information, to ensure we're not missing anything else (and also to serve as a demonstration of passing the right parameters to claimBribes()).
| external | ||
| view | ||
| returns (uint256 totalLQTYAllocated, uint256 offset); | ||
| returns (uint256 totalLQTYAllocated, uint256 offset, uint256 prev, uint256 next); |
Contributor
There was a problem hiding this comment.
Should also update the natspec.
| external | ||
| view | ||
| returns (uint256 lqtyAllocated, uint256 offset); | ||
| returns (uint256 lqtyAllocated, uint256 offset, uint256 prev, uint256 next); |
Contributor
There was a problem hiding this comment.
Should also update the natspec.
| claimDataAtEpoch.prevLQTYAllocationEpoch = userPrevAllocation; | ||
| claimDataAtEpoch.prevTotalLQTYAllocationEpoch = totalPrevAllocation; | ||
|
|
||
| claimData.push(claimDataAtEpoch); |
Contributor
There was a problem hiding this comment.
Thank you, this is awesome!
Contributor
Author
There was a problem hiding this comment.
Thanks to you for pointing it out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.