-
Notifications
You must be signed in to change notification settings - Fork 11
Updated to build with Lispworks 7 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rwiker
wants to merge
1
commit into
lisp:master
Choose a base branch
from
rwiker:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why does lispworks require those compile-time conditionalizations? |
On 8 Jun 2017, at 00:42 , james anderson ***@***.***> wrote:
why does lispworks require those compile-time conditionalizations?
Good question… without the eval-when constructs, I'm getting error messages for defequal constructs where the value is constructed via a macro (e.g, rdf-uri, whitespace-char-p). This might be a bug in Lispworks, or it could be a problem with defequal (which looks good to me).
I'll do a little more digging and see if I can figure this one out; I'll get back to you when/if I know what's happening.
|
i would need specific examples in order to offer any insight into what may be happening... |
On 9 Jun 2017, at 09:29 , james anderson ***@***.***> wrote:
i would need specific examples in order to offer any insight into what may be happening...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABA4OjM4V5Awrx5Tx3Bw0pQmAiVBp96xks5sCPRBgaJpZM4NzNMD>.
ok… without the eval-when forms, I get
CL-USER 1 > (ql:quickload :wilbur)
; "wilbur:base;" = /Users/raw/quicklisp/local-projects/de.setf.wilbur/
To load "wilbur":
Load 1 ASDF system:
wilbur
; Loading "wilbur"
[package wilbur].
**++++ Error between functions:
Undefined operator RDF-URI in form (RDF-URI "ID").
… etc
This indicates that the macro rdf-uri, defined earlier in the file, is somehow not accessible when the compiler sees the form
(defequal -rdf-id-uri- (rdf-uri "ID"))
Wrapping the macro definition for rdf-uri in an eval-when gets rid of the errors in defequal forms that use rdf-uri.
|
if i follow the example, the problem reduces to the passage in the attached file. |
On 9 Jun 2017, at 21:17 , james anderson ***@***.***> wrote:
if i follow the example, the problem reduces to the passage in the attached file.
correct?
testmacro.txt <https://github.com/lisp/de.setf.wilbur/files/1065023/testmacro.txt>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABA4OpC-RHbWuktX0vejT-Zxo-y-kcWnks5sCZoxgaJpZM4NzNMD>.
Absolutely:
;;; Compiling file /private/tmp/testmacro.lisp ...
;;; Safety = 3, Speed = 1, Space = 1, Float = 1, Interruptible = 1
;;; Compilation speed = 1, Debug = 2, Fixnum safety = 3
;;; Source level debugging is on
;;; Source file recording is on
;;; Cross referencing is on
; (TOP-LEVEL-FORM 0)
; (TOP-LEVEL-FORM 1)
; DEFEQUAL
; (DEFCONSTANT -RDF-URI-)
; RDF-URI
**++++ Error between functions:
Undefined operator RDF-URI in form (RDF-URI "ID").
;; Processing Cross Reference Information
; *** 1 error detected, no fasl file produced.
;;; Compilation finished with 0 warnings, 1 error, 0 notes.
…---- Press Space to continue, or press Return to view errors and warnings ----
|
did you make any progress with this. |
On 13 Jun 2017, at 23:28 , james anderson ***@***.***> wrote:
did you make any progress with this.
i have no recent lispworks.
does the issue appear in their "personal edition"?
I'll take another look. I'm pretty sure that this will also affect Lispworks Personal Edition.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small set of changes makes it possible to build with lw7, and does not seem to affect building with sbcl and ccl.