-
Notifications
You must be signed in to change notification settings - Fork 12
add postcss-lit adoption rfc #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
--- | ||
Status: Active | ||
Champions: @43081j | ||
PR: | ||
--- | ||
|
||
# Official postcss/tailwind support | ||
|
||
As part of unifying the standard tools around lit, it would make sense to move | ||
43081j marked this conversation as resolved.
Show resolved
Hide resolved
|
||
the [postcss-lit](https://github.com/43081j/postcss-lit) project into the | ||
lit monorepo as an official solution to inline CSS transforms (e.g. tailwind). | ||
|
||
## Objective | ||
|
||
A strategy for how we will move the project into the monorepo. | ||
|
||
### Goals | ||
- Moving the postcss-lit project into the lit monorepo | ||
- Potentially documenting the project in an appropriate place (or a blog post) | ||
|
||
### Non-Goals | ||
- Transfer of responsibility (it is expected I will continue being the primary | ||
maintainer to avoid extra burden on the lit team) | ||
|
||
## Motivation | ||
|
||
The project already functions well and has high usage, but could benefit hugely | ||
in terms of discovery and support by being in the monorepo. | ||
|
||
- **Discovery:** we are regularly asked by users how to integrate lit with | ||
tailwind and other such CSS solutions. Having an officially supported and | ||
maintained integration will make this clearer | ||
- **Support:** we are more likely to receive community contributions through | ||
issues and pull requests | ||
|
||
It will also become much easier to keep the integration in sync with the | ||
most current version of lit, as we are likely to update it in line with | ||
any breaking changes elsewhere in the monorepo. | ||
|
||
## Detailed Design | ||
|
||
We should be able to migrate the repository to `packages/postcss-lit`, similar | ||
to what we will eventually do with `eslint-plugin-lit`. | ||
43081j marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Alternatively, both could live in the `labs/` project although that may not | ||
make sense since they are both stable projects. | ||
43081j marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
It is likely we want to maintain the same `postcss-lit` name just to avoid | ||
breaking existing setups and to remain consistent with postcss' other custom | ||
syntaxes. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agreed |
||
|
||
43081j marked this conversation as resolved.
Show resolved
Hide resolved
|
||
## Implementation Considerations | ||
|
||
### Implementation Plan | ||
|
||
A single PR should be enough to begin with: copying the existing sources | ||
to the agreed directory and ensuring CI is setup correctly. | ||
|
||
### Backward Compatibility | ||
|
||
N/A | ||
|
||
### Testing Plan | ||
|
||
Existing tests should be enough once copied across. | ||
|
||
### Performance and Code Size Impact | ||
|
||
N/A | ||
|
||
### Interoperability | ||
|
||
N/A | ||
|
||
### Security Impact | ||
|
||
N/A | ||
|
||
### Documentation Plan | ||
|
||
We should create blog posts explaining the two ways users can transform | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @e111077 do you have the Learn section stuff in any form to push to a branch? I could try taking it from there. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. None whatsoever. Heads down on Material work |
||
CSS: | ||
|
||
- Inline CSS via postcss-lit | ||
- External CSS via rollup plugins (using CSS imports) | ||
|
||
These could be linked in the lit website. | ||
|
||
Alternatively, we could document both solutions in the lit website entirely | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Articles" would be my preferred way of doing it, we just don't have a way to surface them right now. |
||
rather than blog posts. | ||
|
||
## Downsides | ||
|
||
N/A | ||
|
||
## Alternatives | ||
|
||
N/A |
Uh oh!
There was an error while loading. Please reload this page.