Kludge to fix multiple autocomplete suggestions with the same label (such as overloads)#170
Open
ethan-skye-white wants to merge 1 commit intolite-xl:masterfrom
Open
Kludge to fix multiple autocomplete suggestions with the same label (such as overloads)#170ethan-skye-white wants to merge 1 commit intolite-xl:masterfrom
ethan-skye-white wants to merge 1 commit intolite-xl:masterfrom
Conversation
Currently, when I'm using jdtls, if I have multiple overloads of the same method, only one will show up in the list. This is because the different overloads will all have the same label. This commit adds invisible characters to the ends of the labels, to make them unique. That's a hideous solution, but it does work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix an issue I've encountered: if there are multiple autocomplete suggestions with the same label (for example, the different overloads of the
ArrayListconstructor if I'm using jdtls), all but one will be hidden. This fix uses a hideous kludge of adding invisible characters to the end of the label to make each suggestion have a unique label. This is only applied on servers with the replace_label property set to true.I'm creating this pull request so that others may use this fix until there's a better solution. I'm interested if anyone can think of a better solution.