Add unit tests for handling invalid LiteDB files#2507
Open
PanWuming wants to merge 2 commits intolitedb-org:masterfrom
Open
Add unit tests for handling invalid LiteDB files#2507PanWuming wants to merge 2 commits intolitedb-org:masterfrom
PanWuming wants to merge 2 commits intolitedb-org:masterfrom
Conversation
Collaborator
|
Does it also work with memorystreams? I prefer not to write on my disk. |
Author
Thank you for your feedback. I have updated the PR with the requested MemoryStream tests and included exception outputs for debugging. Please review the latest changes. |
yz5548
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds four unit tests to handle scenarios where LiteDB attempts to open invalid database files and streams:
Issues
These tests are intended to address issue #2501.
Bugs Discovered
Test_AddDatabase_InvalidDatabase:
LiteDB.LiteExceptionto be thrown.Test_AddDatabase_InvalidDatabase_LargeFile:
LiteDB.LiteExceptionto be thrown.System.ArgumentOutOfRangeExceptionwas thrown.Test_AddDatabase_InvalidDatabase_MemoryStream:
LiteDB.LiteExceptionto be thrown.System.NotSupportedExceptionwas thrown.Test_AddDatabase_InvalidDatabase_LargeFile_MemoryStream:
LiteDB.LiteExceptionto be thrown.System.ArgumentOutOfRangeExceptionwas thrown.These findings indicate that LiteDB is not handling invalid files and streams as expected, leading to different types of exceptions or no exceptions at all.