Fix sendmmsg buffer overrun causing EFAULT when count > 1024 #607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-gflag (sendmmsg) fails with "Bad address" (EFAULT) when the engine attempts to send more than 1024 packets at once.Root Cause
send_packets_using_sendmmsg()declaresstruct mmsghdr mmsgs[1024]on the stack. The initialization loop caps at 1024 elements, but the sendmmsg syscall was invoked with the fullcountparameter:When
count > 1024, the kernel accesses uninitialized memory beyond the array bounds.Changes
Pass the actual number of initialized messages to sendmmsg:
Where
i = min(count, 1024)after the loop.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.