fix: Support SQLAlchemy inheritance patterns#600
Closed
cofin wants to merge 6 commits intolitestar-org:mainfrom
Closed
fix: Support SQLAlchemy inheritance patterns#600cofin wants to merge 6 commits intolitestar-org:mainfrom
cofin wants to merge 6 commits intolitestar-org:mainfrom
Conversation
0524407 to
06f9b18
Compare
Adds Single Table Inheritance (STI), Joined Table Inheritance (JTI), and Concrete Table Inheritance (CTI) support with automatic table handling. - Child classes without explicit __tablename__ use parent table (STI) - Explicit __tablename__ or foreign key creates separate table (JTI) - concrete=True creates independent table (CTI) - Comprehensive tests for all patterns with multiple base classes
…ean up test fixture
- Add automatic detection for STI/JTI/CTI using polymorphic_on check - Capture explicit tablenames in __init_subclass__ before SQLAlchemy processes them - Respect user's explicit tablename choices over auto-generation - Fix test fixture to clear model caches and avoid registry disposal issues - All STI unit tests passing (18/18) - Integration tests fixed by not disposing registry between tests"
5e6203b to
bd33ea8
Compare
Member
Author
|
Superseded by PR #611 which provides a complete implementation with comprehensive test coverage and support for all inheritance patterns (STI, JTI, CTI). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes automatic table name generation to support SQLAlchemy's inheritance patterns.
Changes
Implements detection and handling for:
concrete=TrueImplementation
has_inherited_table()to detect STI pattern and returnNonefor child tablenames__table_cls__hook to inspect columns and prevent duplicate table creation__init_subclass__to settablename=Nonefor STI children before SQLAlchemy processes classExample