Skip to content

Conversation

@HairlessVillager
Copy link
Contributor

Description

Add comprehensive CSV file support to the open_fixture and open_fixture_async functions, expanding the fixture loading capabilities beyond JSON to include comma-separated value files.

Closes

Closes #536

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 66.23377% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.05%. Comparing base (8916358) to head (a084059).

Files with missing lines Patch % Lines
advanced_alchemy/utils/fixtures.py 66.23% 24 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   79.09%   79.05%   -0.05%     
==========================================
  Files          99       99              
  Lines        7861     7915      +54     
  Branches     1065     1073       +8     
==========================================
+ Hits         6218     6257      +39     
- Misses       1301     1315      +14     
- Partials      342      343       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/advanced-alchemy-docs-preview/615

@cofin cofin force-pushed the feat/open-fixture-support-csv branch from fe8e323 to 280ce6b Compare January 18, 2026 15:16
@cofin
Copy link
Member

cofin commented Jan 18, 2026

@HairlessVillager do you mind if i make a few tweaks to this before we merge? Overall, it's not bad but there are few improvements to add.

For instance, I think I don't think we can use splitlines here because you could have a CSV with a line feed within quotation marks of a cell. There are also a few async updates to introduce.

Sorry for the long time between you creating this and my review.

@HairlessVillager
Copy link
Contributor Author

@HairlessVillager do you mind if i make a few tweaks to this before we merge? Overall, it's not bad but there are few improvements to add.

For instance, I think I don't think we can use splitlines here because you could have a CSV with a line feed within quotation marks of a cell. There are also a few async updates to introduce.

Sorry for the long time between you creating this and my review.

Please go ahead with the tweaks, I appreciate you taking the time to review it!

@cofin cofin merged commit 3c98e89 into litestar-org:main Jan 19, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: open_fixture/open_fixture_async support .csv

3 participants