-
-
Notifications
You must be signed in to change notification settings - Fork 511
feat(v3)!: New logging experience #4593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
provinzkraut
wants to merge
16
commits into
main
Choose a base branch
from
fix-logging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cb66a0a
get it working
provinzkraut 472dc25
clean up config
provinzkraut 33d9c85
some refactoring
provinzkraut 7885749
even more refactoring
provinzkraut 039dc05
formatting pass
provinzkraut 3e4f640
remove picologging
provinzkraut d8ecbdf
fix typing
provinzkraut 394e9b5
alter default fields
provinzkraut 29b4b41
docs
provinzkraut 14aa068
simplify logging extra passing
provinzkraut 4b84c6f
typing + formatting
provinzkraut 5bdf9d7
remove picologging remnants
provinzkraut d214396
some testing tweaks
provinzkraut 252f977
Add a note about structlog testing
provinzkraut 486ad0d
typing fixes
provinzkraut c4d3f28
fix extras
provinzkraut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,19 @@ | ||
| from litestar import Litestar, get | ||
| from litestar.logging.config import LoggingConfig | ||
| from litestar.middleware.logging import LoggingMiddlewareConfig | ||
| from litestar.middleware.logging import LoggingMiddleware | ||
|
|
||
| logging_middleware_config = LoggingMiddlewareConfig() | ||
|
|
||
|
|
||
| @get("/", sync_to_thread=False) | ||
| def my_handler() -> dict[str, str]: | ||
| @get("/") | ||
| async def my_handler() -> dict[str, str]: | ||
| return {"hello": "world"} | ||
|
|
||
|
|
||
| app = Litestar( | ||
| route_handlers=[my_handler], | ||
| logging_config=LoggingConfig(), | ||
| middleware=[logging_middleware_config.middleware], | ||
| middleware=[ | ||
| LoggingMiddleware( | ||
| request_log_fields=("query", "body"), # only log query and body fields | ||
| ) | ||
| ], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,5 +5,4 @@ logging | |
| :titlesonly: | ||
|
|
||
| config | ||
| picologging | ||
| standard | ||
| structlog | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| structlog | ||
| ========= | ||
|
|
||
| .. automodule:: litestar.logging.structlog | ||
| :members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,4 +15,3 @@ plugins | |
| problem_details | ||
| prometheus | ||
| pydantic | ||
| structlog | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should consider leaving these pins in.
When i install the dev env, I typically use the lowest supported version for the library (3.10 in this case), but the latest versions of Sphinx have a minimum version of 3.12. We have been running into similar problems with the Advanced Alchemy docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a reason for unpinning this but I can't remember. I'll find out