fix(value_generators): fixes timezone handling for end_date#833
Open
vherr2 wants to merge 1 commit intolitestar-org:mainfrom
Open
fix(value_generators): fixes timezone handling for end_date#833vherr2 wants to merge 1 commit intolitestar-org:mainfrom
vherr2 wants to merge 1 commit intolitestar-org:mainfrom
Conversation
Collaborator
|
Good catch. Can tests be updated to help avoid regression on this behaviour? |
Author
Yes! Let me circle back to this and take a look at getting that done properly 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scanning through the documentation, I noticed an inconsistency in timezone handling. Checking through the related git history in #152 and #236, it seems like this was missed.
I didn't go through and do thorough testing/validation but am happy to spend more time if necessary! Notably, the original tests added as part of #83, did not include tz handling, presumably because it predated that as an option?
Closes
N/A