feat: Enhance Postgres Services with configurable container host #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
container_hostparameter toDockerServicefor flexibility. It defaults to127.0.0.1.postgres_hostfixture to retrieve the host from environment variables if it is set.Closes
This PR partially fixes #86.
I use docker-in-docker and see an error
ValueError: Service 'pytest_databases_postgres' failed to come onlinewhen I try to run unit tests.The root cause of the issue when using this library in the Docker-in-Docker case is the hardcoded
127.0.0.1value as the container host. For Docker-in-Docker, it is necessary to use thehost.docker.internalvalue. This PR allows setting thePOSTGRES_HOSTenvironment variable.P.S. @cofin @peterHoburg @provinzkraut Thank you very much for this library! It seems to me more cool than
testcontainersI used before.