Skip to content

fix(duckdb): correct configuration setup hook #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cofin merged 1 commit into from
Mar 10, 2025
Merged

fix(duckdb): correct configuration setup hook #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions base.py
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions sqlspec/adapters/duckdb/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ def _configure_connection(self, connection: "DuckDBPyConnection") -> None:
Args:
connection: The DuckDB connection to configure.
"""
for config in cast("list[str]", self.config):
connection.execute(config)
for key, value in cast("dict[str,Any]", self.config).items():
connection.execute(f"SET {key}='{value}'")

def _configure_extensions(self, connection: "DuckDBPyConnection") -> None:
"""Configure extensions for the connection.
Expand Down
3 changes: 3 additions & 0 deletions sqlspec/extensions/litestar/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ def on_app_init(self, app_config: "AppConfig") -> "AppConfig":

Args:
app_config: The :class:`AppConfig <.config.app.AppConfig>` instance.

Returns:
The updated :class:`AppConfig <.config.app.AppConfig>` instance.
"""

from sqlspec.base import ConfigManager
Expand Down
54 changes: 27 additions & 27 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.