feat(config): simplify add_config return type
#278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the configuration registry to use `id(config)` as the key instead of `type(config)`, allowing multiple configurations of the same adapter type. - Updated `add_config` method to return the configuration instance instead of its type. - Modified all relevant methods to accept configuration instances directly, removing type-based signatures. - Added validation to raise `ValueError` if a configuration is not registered when accessed. - Introduced a new method `get_config_by_type` to retrieve the first matching configuration by type. - Updated unit tests to cover the new behavior and ensure backward compatibility where necessary.
…gister on first use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_configmethod to return the configuration instance directly and ensure all relevant methods accept configuration instances.