Skip to content

fix: handle None/empty edge cases in SearchFilter and Update.set() #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cofin merged 1 commit into from
Dec 10, 2025
Merged

fix: handle None/empty edge cases in SearchFilter and Update.set() #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sqlspec/builder/_dml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,8 @@ def _process_update_value(self, val: Any, col: Any) -> exp.Expression:
return placeholder

def set(self, *args: Any, **kwargs: Any) -> Self:
if not args and not kwargs:
return self
current_expr = self.get_expression()
if current_expr is None:
self.set_expression(exp.Update())
Expand Down
4 changes: 2 additions & 2 deletions sqlspec/core/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ class SearchFilter(StatementFilter):

__slots__ = ("_field_name", "_ignore_case", "_value")

def __init__(self, field_name: str | set[str], value: str, ignore_case: bool | None = False) -> None:
def __init__(self, field_name: str | set[str], value: str | None, ignore_case: bool | None = False) -> None:
self._field_name = field_name
self._value = value
self._ignore_case = ignore_case
Expand All @@ -668,7 +668,7 @@ def field_name(self) -> str | set[str]:
return self._field_name

@property
def value(self) -> str:
def value(self) -> str | None:
return self._value

@property
Expand Down
7 changes: 1 addition & 6 deletions sqlspec/extensions/litestar/providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,12 +226,7 @@ def provide_search_filter(
),
) -> SearchFilter:
field_names = set(search_fields.split(",")) if isinstance(search_fields, str) else set(search_fields)

return SearchFilter(
field_name=field_names,
value=search_string, # type: ignore[arg-type]
ignore_case=ignore_case or False,
)
return SearchFilter(field_name=field_names, value=search_string, ignore_case=ignore_case or False)

filters[dep_defaults.SEARCH_FILTER_DEPENDENCY_KEY] = Provide(provide_search_filter, sync_to_thread=False)

Expand Down